[video_player] Set audio mix options

[wwwdata]

This is a replacement PR for #1174 because I lost access to the original repository I created the PR from.

How do I make the tests work? Unfortunately, I also had to modify the interface package.

@cyanglaz Pinging you like promised and maybe you can also help me out making the tests green and stuff :) But I have to say this new pigeon method of communicating with the native side is pretty awesome 👍
The only "dirty" thing was that when I created the new dart files, I lost some API test files that apparently were committed to the auto-generated file. I guess that is something that should be moved into a file that is not generated 😄

edited by cyanglaz: fixes flutter/flutter#30438

[cyanglaz]

LGTM % nits
Thank you so much for being patient and going the extra mile to complete this PR!

[wwwdata]

pushed with requested changes.

[cyanglaz]

LGTM. CI seems failing.

[wwwdata]

Yes the CI is failing because it cannot find the new class I added that is in the Interface package. Because it installs the latest released interface package. How to deal with such a situation?

[cyanglaz]

I see! You might want to create a separate PR for the interface change. And we land the interface PR, then we can land the plugin PR.

[wwwdata]

I opened a PR with only changes for the interface package here: #2927
When that is merged I can edit my commit here and remove the interface changes.

[cyanglaz]

@wwwdata The interface change has been published

[wwwdata]

hm, iOS podspec linting seems to be broken. What is causing it? I cannot really make sense of the error messages, can you help?

[cyanglaz]

- ERROR | [iOS] build_pod: Static Analysis failed. You can use `--verbose` for more information. You can use `--no-clean` to save a reproducible buid environment.
Maybe try:
cd ios & pod lib lint --verbose

[wwwdata]

hm, I did that in the packages/video_player/video_player/ios subfolder and for me, it showed that it succeeded

    ** BUILD SUCCEEDED **

   Testing with `xcodebuild`.
 -> video_player (0.0.1)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Building targets in parallel
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - NOTE  | [iOS] xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'video_player' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'Pods-App' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  ld: warning: ignoring file /Users/benbieker/Library/Developer/Xcode/DerivedData/App-hdhkmassaptsdagmgypnbhjsradv/Build/Products/Release-iphonesimulator/video_player/video_player.framework/video_player, building for iOS Simulator-i386 but attempting to link with file built for iOS Simulator-x86_64
    - NOTE  | [iOS] xcodebuild:  ld: warning: ignoring file Flutter/Flutter.framework/Flutter, missing required architecture i386 in file Flutter/Flutter.framework/Flutter (3 slices)
    - NOTE  | [iOS] xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'App' from project 'App')

video_player passed validation.

[cyanglaz]

@wwwdata That's weird. I'm kicking off a re-run.

[wwwdata]

hmm, seems to be the same issue. Is there anybody else that can help? I don't really see the concrete error message in the build log output as well. So I don't know how to fix it right now, unfortunately.

[cyanglaz]

I think we need to depend on the newly published platform interface plugin here?

[cyanglaz]

@jmagman Could you help us take a look :)
The ci says pod lib lint throws some error but both @wwwdata and I have tried locally with the same code and pod lib lint passed validation. Maybe we are missing something?

[jmagman]

It's a bunch of null check static analyzer warnings, the line numbers are pointing to the right spot. Instead of (self.textureId ? self.textureId : [NSNull null]) you need to say (self.textureId != nil ? self.textureId : [NSNull null]) etc

    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/messages.m:59:51: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/messages.m:111:37: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/messages.m:112:37: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/messages.m:132:37: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/messages.m:133:37: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/messages.m:152:37: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/messages.m:153:37: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/messages.m:169:37: warning: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
    - WARN  | [iOS] xcodebuild:  /private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/video_player/video_player/ios/Classes/FLTVideoPlayerPlugin.m:505:5: warning: nil returned from a method that is expected to return a non-null value

[jmagman]

@jmagman Could you help us take a look :)
The ci says pod lib lint throws some error but both @wwwdata and I have tried locally with the same code and pod lib lint passed validation. Maybe we are missing something?

Run with --analyze and you'll see it.

[wwwdata]

@jmagman interesting. Fixing all the lint "warnings" actually made the check green. What is confusing me about this is that the code was generated from code generation inside the messages.m file and the other part that complains about the nil return value in the create method was also code I did not touch :P So how was this working and got merged before?

Do those linting errors now pop up because of some linter rule changes maybe? It will be an issue the next time somebody runs the code auto-generation again. So I guess manually fixing it should not be the solution.

[wwwdata]

Ok, I think I got it now and the tests should become green. So It seems that the auto-generated code must have been manually edited. So I went over the diff and undid everything the code generator incorrectly generated.

[LockedThread]

I just want to say thank you so much for working on this because I've been waiting on this to be pushed publicly for about a year now. Once this is published, I won't have to keep my fork of this going on.

[cyanglaz]

@jmagman interesting. Fixing all the lint "warnings" actually made the check green. What is confusing me about this is that the code was generated from code generation inside the messages.m file and the other part that complains about the nil return value in the create method was also code I did not touch :P So how was this working and got merged before?

Do those linting errors now pop up because of some linter rule changes maybe? It will be an issue the next time somebody runs the code auto-generation again. So I guess manually fixing it should not be the solution.

@gaaclarke Might know.

[jmagman]

@gaaclarke Looks like
https://github.com/flutter/packages/blob/cf96cba3c50a410e9b450d0a24ea9d7e1c020c09/packages/pigeon/lib/objc_generator.dart#L177 causes an analyzer warnings for NSNumbers.

[gaaclarke]

I spawned an issue for the analysis issue: flutter/flutter#63966 Thanks =)

[cyanglaz]

Offline discussion with @gaaclarke. We are ok with manually editing the auto-generated code to pass CI for now, and fix pigeon later.

[dnfield]

Master started timing out after this commit. I'm going to take a quick look and see if reverting it resolves the timeout.

[cyanglaz]

@wwwdata This PR broke post submit ci. I reverted here #2938

[cyanglaz]

Looks like this is not the cause of the time out. Relandded in #2939

[pedromassangocode]

Fixed flutter/flutter#66799 as well