-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] Add TileOverlay support #2077
Conversation
Update master
Update master
Update from master
Update master
Update master
Update master
@iskakaushik Hi! UPD: |
Update master
# Conflicts: # packages/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/pubspec.yaml
Update master
# Conflicts: # packages/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/pubspec.yaml
Update master
# Conflicts: # packages/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/pubspec.yaml
@iskakaushik Any updates? |
update master
Update master
How do I use this build? I am currently running flutter_google_maps 1.0.2 build. |
@queendevelopers This build has been initially developed on the 0.5.25 version of google_maps_flutter, but it was blocked by the release of the web support, which required a lot of the code developed by me and @otopba to be rewritten in order to support the "new" The PR is blocked from that moment and I didn't had the time to fix it, but if you want to help it to conclude this development this is surely appreciated |
@otopba Thank you for implementation! I found a mystery. "Tile overlays" only works after _onMapCreated is called in ios. "example" is the tile overlay addition after _onMapCreated. So I wrote this.
Is that a matter of course? |
update master
# Conflicts: # packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/google_maps_flutter/example/lib/main.dart # packages/google_maps_flutter/google_maps_flutter/lib/google_maps_flutter.dart # packages/google_maps_flutter/google_maps_flutter/lib/src/controller.dart # packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart # packages/google_maps_flutter/google_maps_flutter/pubspec.yaml
# Conflicts: # packages/google_maps_flutter/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapFactory.java
Just set this branch as source for Google Maps inside your pubspec file |
Could you check it in native app? |
@cyanglaz friendly ping |
# Conflicts: # packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md # packages/google_maps_flutter/google_maps_flutter/pubspec.yaml # packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md
This reverts commit 4825de1
@cyanglaz Seems like the build cannot pass since we are doing changes on either If I set the dependency of If I use a Do we need to open a new MR with only the changes on |
@jweidner-mbible Thank you for your tip, I added the fix now. @yamamotodin The bug you found on iOS is now fixed on the latest commit. |
@neokree let's fork a PR that only contains platform_interface changes. Then we can publish the platform interface changes first. |
This is being worked on at #3434, I'm closing the PR :) |
Description
Add TileOverlay support.
Related Issues
flutter/flutter#25942
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change