Update master #11
Merged
Update master #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a rule just for `android_intent` that makes sure that there are no undocumented public members. This will prevent the DartDocs from regressing. Also updates the main repo's analysis options to migrate from some deprecated options. If/when all the plugins have their DartDocs updated this package-specific `analysis_options.yaml` should be removed, and the DartDoc rule should be moved up to the top level.
35e984f migrated some deprecated analyzer warnings to the newer alternatives. These created some failures in unrelated plugins based on the warnings being slightly different. Added `ignore`s for now to turn CI green again as soon as possible. The previous analysis options really should not be used and the majority of the patch was unrelated, so I prefer ignoring specific already failing cases to reverting in this case. Including an `analysis_options.yaml` file with deprecated analyzer rules causes analyzer failures in the including package, so that patch can't be landed in a way that prevents regressions without updated rules.
Missing DartDocs were recently added to this plugin. Add a package-specific analysis options to make sure that they don't regress going forward.
Missing DartDocs were recently added to this plugin. Add a package-specific analysis options to make sure that they don't regress going forward.
- Add missing dartdoc coverage and expand on existing documentation. - Add an analyzer warning for this package so that public doc coverage doesn't regress. - Improve unit test coverage. - Expand on the existing README.
- Adds support in the plugin - Adds a v2 embedding to the example app - Fixes a broken remote example in the example app - Increments the Flutter SDK dependency - Increments the version - Adds e2e tests for some simple use cases of the plugin
- Add a lint to url_launcher and url_launcher_platform_interface to prevent undocumented public members. - Add some unit tests.
Previously all navigation decisions needed to be made synchronously in Dart. The platform layers are already waiting for the MethodChannel callback, so just changed the return type to be `FutureOr<NavigationDecision>'. This is a change to the method signature of `WebViewPlatformCallbacksHandler#onNavigationRequest`, but that interface appears to only be meant to be implemented internally to the plugin.
…2266) * Port google_sign_in.dart to use the federated Platform Interface, instead of MethodChannels. * Ignore google_sign_in_platform_interface on all-plugins-app call. * Refactor endlessly growing --exclude param value into a string that gets generated for a list of plugin names.
* Look at the README.md of this package for usage instructions. Please file issues for platform: web so we see them!
Also adds a lint to prevent future undocumented public APIs.
* Move plugin to subdir * Add video_player_platform_interface * Make analyzer happy * Improve documentation * Bump version and update changelog * Add stream of VideoEvent * Ignore deprecated_member_use * Improve changelog message and version * Use DataSource class * Add duration, size and buffering to VideoEvent * Seek to Duration * Fix buffering update * Adapt docstring * Add buildView
* Fix testing instructions in CONTRIBUTING.md
Removes obsolete recommendations about removing mockito (which is now used in testing federated plugins, see firebase/flutterfire#1472).
Also adds a lint to prevent undocumented APIs going forward.
Also adds a lint to prevent further undocumented methods.
Adds a little more info on how to use the plugin. Also adds linter options to prevent any undocumented APIs from being added in the future.
Switches our out of date fork of Flutter's analysis rules to the pedantic package. In order to make this an easy change to initially land and then incrementally enable, any existing non-trivial lints have just been ignored within their respective packages instead of being fixed. Also adds a global lint for missing public DartDocs. Like the pedantic lints, this is ignored in packages that are already failing it.
This provides information on how to publish plugins going forward with the new `flutter_plugin_tools publish-plugin` command. In addition to that this documents our general process, which is a general team health issue we've been wanting to fix for awhile.
* add shared_preferences_platform_interface
Also adds a lint to prevent undocumented DartDocs from being added in the future. Some of the APIs were public when they really should have been `@visibleForTesting` or even private. Added some `@visibleForTesting` annotations as well.
* [android_alarm_manager] Testing and documentation Unit tests the plugin, and adds a lint for missing DartDocs. * Review feedback - Wrap InstanceWrappers into a single `setTestOverride` method. - Replace potentially garbage collected lambdas with top level functions. * Review feedback
Add an empty podspec file, so this plugin doesn't break compilation on IOS. This should fix flutter/flutter#45571
There's a over a dozen API surfaces that are undocumented still. This just fixes one of the new pedantic lints.
Add google_sign_in_web to lint_darwin_plugins.sh so its dummy podspec isn't validated.
* implement shared_preferences on top of platform interface
* [video_player] Use platform interface * Move tests (leftover from part1) * Merge master * Export DurationRange and DataSourceType * Export VideoFormat * ignore: unused_element * Format * Update video_player_platform_interface dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.