Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] Add note that canLaunch only works for some schemes #2722

Closed
wants to merge 1 commit into from

Conversation

tp
Copy link

@tp tp commented Apr 29, 2020

And that some configuration is necessary to support custom schemes.

Description

Document that iOS apps need to be configured to allow querying for non-standard URL schemes.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

And that some configuration is necessary to support custom schemes.
@tp
Copy link
Author

tp commented Apr 29, 2020

Please let me know if this is a good place to document this behavior, or if you would rather prefer a note on the README.

@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

Since #3252 addresses this same concern (via the README, which is where we generally document permissions), and has already been reviewed, I'm going to go ahead and close this. Apologies for the unfortunate duplication due to this PR not having been triaged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants