[url_launcher] Update readme for URL schemes on iOS #3252

TahaTesser · 2020-11-06T15:29:30Z

Description

Add instructions for iOS, for targeting iOS 9.0 and higher.
Note:
All new projects 1.22+ targets iOS 9.0 by default

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

hamdikahloun · 2020-11-06T21:31:17Z

packages/url_launcher/url_launcher/pubspec.yaml

@@ -2,7 +2,7 @@ name: url_launcher
 description: Flutter plugin for launching a URL on Android and iOS. Supports
  web, phone, SMS, and email schemes.
 homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
-version: 5.7.10
+version: 5.7.10+1


The next PATCH version must be 5.7.11

Update doc can be just bumped by +1
Example
https://pub.dev/packages/image_picker/changelog#06710
https://pub.dev/packages/url_launcher/changelog#0421
https://pub.dev/packages/google_maps_flutter/changelog#052113

Also example from my last PR
https://github.com/flutter/plugins/pull/2932/files

@TahaTesser

For package versions > 1.0.0, we shouldn't do +z .

Details in https://dart.dev/tools/pub/versioning#semantic-versions

Running version check for changed packages packages/url_launcher/url_launcher/pubspec.yaml incorrectly updated version. HEAD: 5.7.10+1, master: 5.7.10. Allowed versions: {6.0.0: NextVersionType.BREAKING_MAJOR, 6.0.0-nullsafety: NextVersionType.MAJOR_NULLSAFETY_PRE_RELEASE, 5.8.0-nullsafety: NextVersionType.MINOR_NULLSAFETY_PRE_RELEASE, 5.8.0: NextVersionType.MINOR, 5.7.11: NextVersionType.PATCH}

That's interesting, made the changes required.
Thank you

hamdikahloun · 2020-11-07T12:03:24Z

packages/url_launcher/url_launcher/README.md

+
+```
+<key>LSApplicationQueriesSchemes</key>
+<array>


Does this cover other Schemes like mailto, tel and sms, or we must add new items for this property?

Those schemes are supported without adding this so no new items are required

TahaTesser · 2020-12-03T10:34:12Z

CC: @cyanglaz

TahaTesser · 2021-02-03T09:17:26Z

@hamdikahloun
Is there anything we need to merge this?
Thank you

hamdikahloun · 2021-02-03T10:10:01Z

hi @TahaTesser
Last time i checked it, the branch has conflicts that must be resolved .
Please fix the conflicts before merging .
Thank you

hamdikahloun

LGTM

TahaTesser · 2021-02-03T12:11:21Z

@hamdikahloun
Just rebased and bumped version, update changelog
I've removed the When targeting iOS 9.0+, new default from Flutter 1.22+. line since this version of stable has been around for months
Can you please review the current updated PR?
Thank you

hamdikahloun · 2021-02-03T12:22:23Z

@hamdikahloun
Just rebased and bumped version, update changelog
I've removed the When targeting iOS 9.0+, new default from Flutter 1.22+. line since this version of stable has been around for months
Can you please review that current updated PR?
Thank you

LGTM

darshankawar · 2021-02-08T13:50:05Z

LGTM

stuartmorgan-g · 2021-02-08T15:33:01Z

packages/url_launcher/url_launcher/README.md

+
+### iOS 
+
+Add the following keys to your _Info.plist_ file, located in `<project root>/ios/Runner/Info.plist`:


This is not an accurate summary of the requirement, and may still cause confusion. The correct description is that the scheme of any URL they pass to canLaunch should be listed, and the README should say that. You can give the below as an example, but you should make clear that it's an example.

Made the changes, thanks!

darshankawar · 2021-02-12T11:02:13Z

packages/url_launcher/url_launcher/README.md

+## Installation
+
+### iOS 
+Add scheme for any URL passed on `canLaunch` to your _Info.plist_ file.  


May be "Add any URL scheme passed to canLaunch in your Info.plist file."

darshankawar · 2021-02-19T05:29:50Z

LGTM

stuartmorgan-g

LGTM with nits

stuartmorgan-g · 2021-02-19T15:17:54Z

packages/url_launcher/url_launcher/README.md

+## Installation
+
+### iOS 
+Add any URL scheme passed to canLaunch in your Info.plist file.


Nits:

Add `s around canLaunch

s/in your/as LSApplicationQueriesSchemes entries in your/

stuartmorgan-g · 2021-02-19T15:21:10Z

packages/url_launcher/url_launcher/README.md

+</array>
+```
+
+See [canOpenURL](https://developer.apple.com/documentation/uikit/uiapplication/1622952-canopenurl) for more details.


Nit: the standard way to refer to an OjbC method without context includes the class, and the full signature (which includes the - and the :), like: -[UIApplication canOpenURL:]

See [`-[UIApplication canOpenURL:]`](...) for more details.

TahaTesser · 2021-03-02T13:54:31Z

@stuartmorgan
Sorry for the delay, made the changes.

stuartmorgan-g

LGTM!

stuartmorgan-g · 2021-03-19T18:30:31Z

I've restarted the failed test, since it was a network issue.

…plugins#3252)

TahaTesser requested a review from mklim as a code owner November 6, 2020 15:29

google-cla bot added the cla: yes label Nov 6, 2020

TahaTesser mentioned this pull request Nov 6, 2020

[url_launcher] Launching URLs breaks on iOS 14 with Chrome as default browser flutter/flutter#65936

Closed

hamdikahloun reviewed Nov 6, 2020

View reviewed changes

hamdikahloun reviewed Nov 7, 2020

View reviewed changes

TahaTesser mentioned this pull request Dec 4, 2020

URL Launcher Plugin fails to verify canLaunch flutter/flutter#71634

Closed

TahaTesser mentioned this pull request Dec 22, 2020

await url_launcher.launch() returns null (iOS only) flutter/flutter#45900

Closed

TahaTesser mentioned this pull request Jan 4, 2021

[url_launcher] on iPhone with Firefox canLaunch returns false, but launch works flutter/flutter#73224

Closed

stuartmorgan-g added the p: url_launcher label Jan 29, 2021

hamdikahloun approved these changes Feb 3, 2021

View reviewed changes

TahaTesser force-pushed the url_launcher_readme_update branch 2 times, most recently from a9ab05d to e17673e Compare February 3, 2021 12:09

darshankawar approved these changes Feb 8, 2021

View reviewed changes

stuartmorgan-g suggested changes Feb 8, 2021

View reviewed changes

TahaTesser changed the title ~~[url_launcher] Update readme for iOS targeting iOS 9.0 and higher~~ [url_launcher] Update readme for URL schemes on iOS Feb 11, 2021

darshankawar reviewed Feb 12, 2021

View reviewed changes

TahaTesser force-pushed the url_launcher_readme_update branch from 002d571 to b3ba69b Compare February 16, 2021 10:33

stuartmorgan-g approved these changes Feb 19, 2021

View reviewed changes

stuartmorgan-g mentioned this pull request Feb 24, 2021

[url_launcher] Add note that canLaunch only works for some schemes #2722

Closed

13 tasks

TahaTesser added 4 commits March 2, 2021 19:12

updste readme

c796a58

update and rebase

cf8a395

Update README

03b5f62

update README

2781fd9

TahaTesser force-pushed the url_launcher_readme_update branch from b3ba69b to 2781fd9 Compare March 2, 2021 13:48

fixed description

a7ce775

stuartmorgan-g approved these changes Mar 19, 2021

View reviewed changes

stuartmorgan-g added the last mile label Mar 19, 2021

stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 23, 2021

fluttergithubbot merged commit 7173380 into flutter:master Mar 23, 2021

engine-flutter-autoroll mentioned this pull request Mar 23, 2021

Roll Plugins from d7125cdb91c0 to 7173380dd3f5 (13 revisions) flutter/flutter#78891

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021

7173380 [url_launcher] Update readme for URL schemes on iOS (flutter/…

f9688cc

…plugins#3252)

github-actions bot added the needs-publishing label Mar 23, 2021

engine-flutter-autoroll mentioned this pull request Mar 23, 2021

Roll Plugins from d7125cdb91c0 to 9548bc27af5d (14 revisions) flutter/flutter#78900

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021

7173380 [url_launcher] Update readme for URL schemes on iOS (flutter/…

3cedeaf

…plugins#3252)

engine-flutter-autoroll mentioned this pull request Mar 24, 2021

Roll Plugins from d7125cdb91c0 to ce1cf17352f1 (17 revisions) flutter/flutter#78982

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021

7173380 [url_launcher] Update readme for URL schemes on iOS (flutter/…

c8be1fa

…plugins#3252)

engine-flutter-autoroll mentioned this pull request Mar 24, 2021

Roll Plugins from d7125cdb91c0 to ce1cf17352f1 (17 revisions) flutter/flutter#78993

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021

7173380 [url_launcher] Update readme for URL schemes on iOS (flutter/…

a04b2fb

…plugins#3252)

engine-flutter-autoroll mentioned this pull request Mar 25, 2021

Roll Plugins from d7125cdb91c0 to eab885b84b99 (29 revisions) flutter/flutter#79069

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021

7173380 [url_launcher] Update readme for URL schemes on iOS (flutter/…

27ab066

…plugins#3252)

stuartmorgan-g removed last mile labels Mar 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[url_launcher] Update readme for URL schemes on iOS #3252

[url_launcher] Update readme for URL schemes on iOS #3252

TahaTesser commented Nov 6, 2020

hamdikahloun Nov 6, 2020 •

edited

Loading

TahaTesser Nov 7, 2020

hamdikahloun Nov 7, 2020

TahaTesser Nov 7, 2020

hamdikahloun Nov 7, 2020

TahaTesser Dec 3, 2020

TahaTesser commented Dec 3, 2020

TahaTesser commented Feb 3, 2021

hamdikahloun commented Feb 3, 2021

hamdikahloun left a comment

TahaTesser commented Feb 3, 2021 •

edited

Loading

hamdikahloun commented Feb 3, 2021

darshankawar commented Feb 8, 2021

stuartmorgan-g Feb 8, 2021

TahaTesser Feb 18, 2021

darshankawar Feb 12, 2021

darshankawar commented Feb 19, 2021

stuartmorgan-g left a comment

stuartmorgan-g Feb 19, 2021

stuartmorgan-g Feb 19, 2021

TahaTesser commented Mar 2, 2021

stuartmorgan-g left a comment

stuartmorgan-g commented Mar 19, 2021


		### iOS

		Add the following keys to your _Info.plist_ file, located in `<project root>/ios/Runner/Info.plist`:

[url_launcher] Update readme for URL schemes on iOS #3252

[url_launcher] Update readme for URL schemes on iOS #3252

Conversation

TahaTesser commented Nov 6, 2020

Description

Related Issues

Checklist

Breaking Change

hamdikahloun Nov 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TahaTesser commented Dec 3, 2020

TahaTesser commented Feb 3, 2021

hamdikahloun commented Feb 3, 2021

hamdikahloun left a comment

Choose a reason for hiding this comment

TahaTesser commented Feb 3, 2021 • edited Loading

hamdikahloun commented Feb 3, 2021

darshankawar commented Feb 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darshankawar commented Feb 19, 2021

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TahaTesser commented Mar 2, 2021

stuartmorgan-g left a comment

Choose a reason for hiding this comment

stuartmorgan-g commented Mar 19, 2021

hamdikahloun Nov 6, 2020 •

edited

Loading

TahaTesser commented Feb 3, 2021 •

edited

Loading