Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[plugin_platform_interface]fix:GoLink inaccessible #2880

Closed
wants to merge 1 commit into from
Closed

[plugin_platform_interface]fix:GoLink inaccessible #2880

wants to merge 1 commit into from

Conversation

jarrodcolburn
Copy link

@jarrodcolburn jarrodcolburn commented Jul 15, 2020

@amirh On pub.dev/packages/plugin_platform_interface the link to "federated flutter plugins" is fluter.dev/go/federated-plugins.
However, that GoLink does not appear to be accessible to non-googlers, like myself.
I was able to find a Google Doc by searching for "federated" on flutter.dev docs at https://flutter.dev/search?q=federated and clicking (2nd result right now) and I was able to click GoLink when using same domain.
Otherwise, I am unable to use link provided.

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@amirh On pub.dev/packages/plugin_platform_interface the link to "federated flutter plugins" is fluter.dev/go/federated-plugins.
However, that GoLink does not appear to be accessible to non-googlers, like myself.
I was able to find a Google Doc by searching for "federated" on flutter.dev docs at https://flutter.dev/search?q=federated and clicking (2nd result right now) and I was able to click GoLink when using same domain.
Otherwise, I am unable to use link provided.
@ditman
Copy link
Member

ditman commented Jul 21, 2020

@JarrodCColburn can you try again going to https://flutter.dev/go/federated-plugins?

It seems that the internal redirection had disappeared. I just recreated it.

@jarrodcolburn
Copy link
Author

@JarrodCColburn can you try again going to https://flutter.dev/go/federated-plugins?

It seems that the internal redirection had disappeared. I just recreated it.

There is still al problem, but I was wrong about the cause. It appears to be a typo. Please see issue #2888

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants