[plugin_platform_interface] typo in link #2888
Conversation
The link for federated flutter plugins https://fluter.dev/go/federated-plugins, fluter.dev is missing second 't'. `fluter` vs `flutter`
|
Ohh, good catch! Can you do a patch version bump in this package's pubspec.yaml and CHANGELOG.md? That way we can publish the fix to pub.dev. (I think v |
Yes, I'll try. Since that requires editing the changelog anyways. Can I go ahead and incorporate issue #2879 ? Pubspec.yaml homepage is: corrected: (add packages) |
|
@JarrodCColburn yes, please! Thanks for consolidating all the fixes to this package! |
|
Updated. |
|
I had to fix the versioning, analyzer didn't like 1.0.2+1 (not sure why), so I bumped this to 1.0.3. I'll merge this as soon as the CI passes! |
|
@JarrodCColburn do you mind rebasing this with the latest master? The test that is failing was fixed a few days ago. Thanks! |
…port path" (flutter#2896) * Revert "[path_provider] Use the application ID in the application support path (flutter#2845)" This reverts commit 7d4a918. * bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.
* Make package:e2e a relative reference
…ils (flutter#2866) * [e2e] Fix incorrect test results when one test passes then another fails For example, the following test will result in an error reported for the first test case. ``` void main() { testWidgets('a test that passes', (tester) async { expect(true, true); }); testWidgets('a test that fails', (tester) async { expect(true, false); }); } ``` We need to reset `reportTestException` back to the previous value after completion of `runTest`, or repeated failures will cause the exception handler for a previous test to be invoked, as they "stack". Instead of reseting it, however, do this once in the constructor because the test description is already provided by the function signature. * Add a mechanism for testing test results
* clarify e2e on firebase
…n. (flutter#2903) This change tweaks slightly the core maps plugin and the platform interface package to make the web implementation possible. The most important changes are two: * The core plugin now passes a constant identifier to the buildView platform call, so the web version can cache effectively the contents of the platform view, so it doesn't repaint. This might go away once Scenelets for web come online. * The platform interface now encodes the (optional) width and height of custom Icons for Markers, so the web can render High DPI assets at the correct size. The rest are some examples to the 'example' app so it can be run on web.
…#2908) This method gives the plugin writers a chance to release the resources that they've acquired throughout the operation of the plugin (think of it as an "inverse" of the "init" method).
(To be moved to flutter_test)
(This is preparation for the federation of the plugin)
package:platform required a breaking change in the behavior of FakePlatform in order to enable null safety, but there will be no other breaking changes in 3.X Since this does not affect path provider or local_auth, the pubspec constraint can be increased.
…lutter#2938)" (flutter#2939) This reverts commit d4750ea.
* Use shard variables correctly in incremental_build.sh * Add more shards for the apk tasks.
This is the platform interface package of the federated device_info plugin.
This package introduces the first version of the google_maps_flutter_web plugin. See README for installation instructions. Co-authored-by: chung2012 <[email protected]>
* e2e -> integration_test and associated version bumps
jarrodcolburn
requested review from
amirh,
bkonyi,
bparrishMines,
cyanglaz,
dnfield,
LHLL,
matthew-carroll and
mklim
as code owners
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@ditman I tried. Can you check that it looks right? Not used to rebasing on large projects. It pulled in a bunch of stuff and looks either 100% right or 100% wrong, but I can't tell. If wrong, let me know and I'll take another swing at it. thanks |
|
This is looking a bit weird. How did you rebase your branch? |
|
This pull request is not suitable for automatic merging in its current state.
|
|
I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA. |
The link for federated flutter plugins https://fluter.dev/go/federated-plugins,
fluter.dev is missing second 't'.
flutervsflutterDescription
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?