Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[share] Migrate to null-safety #3311

Merged
merged 3 commits into from
Dec 15, 2020
Merged

[share] Migrate to null-safety #3311

merged 3 commits into from
Dec 15, 2020

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Dec 9, 2020

Description

Migrate share plugin to null safety.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@mehmetf mehmetf requested a review from amirh December 9, 2020 01:20
@blasten
Copy link

blasten commented Dec 12, 2020

This needs to be added to https://github.com/flutter/plugins/blob/master/script/nnbd_plugins.sh#L8

@mehmetf mehmetf requested a review from blasten December 15, 2020 14:19
blasten
blasten approved these changes Dec 15, 2020
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehmetf mehmetf merged commit 88466ff into flutter:master Dec 15, 2020
@mehmetf mehmetf deleted the b006 branch December 15, 2020 16:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
c5c0681
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
91c99fd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
8001b64
NickalasB added a commit to NickalasB/plugins that referenced this pull request Dec 15, 2020
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
e35a717 
* master:
  [android_intent] Migrate to nnbd (flutter#3328)
  [share] Migrate to null-safety (flutter#3311)
  [webview_flutter] Migrate to nnbd (flutter#3327)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/lib/webview_flutter.dart
#	packages/webview_flutter/pubspec.yaml
#	packages/webview_flutter/test/webview_flutter_test.dart
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
3098720
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
6313126
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
552ad9f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
df58235
blasten pushed a commit that referenced this pull request Dec 16, 2020
Revert "[share] Migrate to null-safety (#3311)"
f6cb274 
This reverts commit 88466ff.
@blasten blasten mentioned this pull request Dec 16, 2020
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
638e93b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
b2a9aff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
8b6aeb4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
a997e28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
afe6386
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
a054f76
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
6b9e69a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
c9b28d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
4102ebf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
8b656a0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 29, 2020
@engine-flutter-autoroll
88466ff [share] Migrate to null-safety (flutter/plugins#3311)
7fe9871
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
@mehmetf @amantoux
[share] Migrate to null-safety (flutter#3311)
684d840
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
@mehmetf @adsonpleal
[share] Migrate to null-safety (flutter#3311)
79ae846
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

@amirh amirh Awaiting requested review from amirh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehmetf @blasten