Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Migrate to nnbd #3327

Merged
merged 4 commits into from
Dec 15, 2020
Merged

[webview_flutter] Migrate to nnbd #3327

merged 4 commits into from
Dec 15, 2020

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Dec 14, 2020

Description

Migrate webview_flutter to nnbd.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mehmetf mehmetf requested a review from amirh as a code owner December 14, 2020 18:05
@google-cla google-cla bot added the cla: yes label Dec 14, 2020
@mehmetf mehmetf changed the title Migrate webview_flutter to nnbd [webview_flutter] Migrate to nnbd Dec 14, 2020
@mehmetf
Copy link
Contributor Author

mehmetf commented Dec 15, 2020

@blasten Please LGTM. Amir already reviewed these changes. Also, let me know if format failure is a concern or whether I can ignore it.

@blasten
Copy link

blasten commented Dec 15, 2020

yes. The format issue appears to be a bug caused by skipping the Dart files once you added it to nnbd_plugins.sh.
https://github.com/flutter/plugin_tools/blob/master/lib/src/format_command.dart#L118

I will take care of this issue.

LGTM

@mehmetf mehmetf merged commit 78eff18 into flutter:master Dec 15, 2020
@mehmetf mehmetf deleted the webview_nnbd branch December 15, 2020 16:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
f868051
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
313002d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
c6bc9c1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
62c2810
NickalasB added a commit to NickalasB/plugins that referenced this pull request Dec 15, 2020
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
e35a717 
* master:
  [android_intent] Migrate to nnbd (flutter#3328)
  [share] Migrate to null-safety (flutter#3311)
  [webview_flutter] Migrate to nnbd (flutter#3327)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/lib/platform_interface.dart
#	packages/webview_flutter/lib/webview_flutter.dart
#	packages/webview_flutter/pubspec.yaml
#	packages/webview_flutter/test/webview_flutter_test.dart
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
0eefe2c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
1a8af3b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
ed0fb35
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
9e3b594
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
31a11ad
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
9138d20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
f76b65d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
bb2ef73
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
385bc9d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
53696e1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
6db530a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
cedde28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
799c14c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
cea0b54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 29, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 29, 2020
@engine-flutter-autoroll
78eff18 [webview_flutter] Migrate to nnbd (flutter/plugins#3327)
7ba40a4
amantoux pushed a commit to amantoux/plugins that referenced this pull request Feb 8, 2021
@mehmetf @amantoux
[webview_flutter] Migrate to nnbd (flutter#3327)
2ead6c7
adsonpleal pushed a commit to nubank/plugins that referenced this pull request Feb 26, 2021
@mehmetf @adsonpleal
[webview_flutter] Migrate to nnbd (flutter#3327)
ba38f03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blasten blasten blasten approved these changes

@amirh amirh Awaiting requested review from amirh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehmetf @blasten