Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] The alert should be called in the main thread. #3351

Closed
wants to merge 1 commit into from

Conversation

callbiruk
Copy link

This fix resolves:
(NSException *) exception = 0x0000000280f86df0 name: "NSInternalInconsistencyException" - reason: "Modifications to the layout engine must not be performed from a background thread after it has been accessed from the main thread."

Description

This PR resolves an issue for a complete app crash when the biometric lockout happens in the app. The alert throws an error claiming the UI modification should happen in the main thread instead of the background process. Therefore, I run the function in the main thread and wrap it on try catch block for any failure.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This fix resolves:
(NSException *) exception = 0x0000000280f86df0 name: "NSInternalInconsistencyException" - reason: "Modifications to the layout engine must not be performed from a background thread after it has been accessed from the main thread."
@google-cla
Copy link

google-cla bot commented Dec 18, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Dec 18, 2020
@cyanglaz
Copy link
Contributor

I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA.

@cyanglaz cyanglaz closed this Jan 14, 2021
@callbiruk
Copy link
Author

@googlebot I signed it!

I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA.

@googlebot I signed it!

@cyanglaz cyanglaz reopened this Jan 15, 2021
@cyanglaz
Copy link
Contributor

@googlebot I fixed it

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 15, 2021
@cyanglaz cyanglaz changed the title The alert should be called in the main thread. [local_auth] The alert should be called in the main thread. Jan 15, 2021
Copy link
Author

@callbiruk callbiruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyanglaz Request for approval.

@stuartmorgan-g
Copy link
Contributor

Closing as a duplicate of #3352

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants