Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Fix iOS app crash issue: alerts should be alled in the m… #3352

Conversation

callbiruk
Copy link

Fix an issue raised in Xcode:
(NSException *) exception = 0x0000000280f86df0 name: "NSInternalInconsistencyException" - reason: "Modifications to the layout engine must not be performed from a background thread after it has been accessed from the main thread."

Description

This PR resolves an issue for a complete app crash when the biometric lockout happens in the app. The alert throws an error claiming the UI modification should happen in the main thread instead of the background process. Therefore, I run the function in the main thread and wrap it on try catch block for any failure.

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@MichaelPretorius
Copy link

@callbiruk are you planning on updating your PR so it can pass checks and be merged?

Copy link
Author

@callbiruk callbiruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelPretorius CHANGELOG.md

@ttmdung203
Copy link

@callbiruk are you planning on updating your PR so it can pass checks and be merged?

Yes, I've the same question. Thanks @callbiruk for your contribution. I'm looking forward to seeing the this update too.

@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! This is obsoleted by #3778 (which fixed the underlying threading issue rather than just this specific symptom), so closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants