Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Adopt Xcode 12 for podspec lints #3653

Merged
merged 1 commit into from
Mar 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,26 +202,6 @@ task:
# This UI change sometimes affects `xctest`.
# So we run `drive-examples` after `xctest`, changing the order will result ci failure.
- ./script/incremental_build.sh drive-examples --ios

task:
# Xcode 11 task
# TODO(cyanglaz): merge Xcode 11 task to Xcode 12 task when all the matrix can be run in Xcode 12.
# don't run on release tags since it creates O(n^2) tasks where n is the number of plugins
only_if: $CIRRUS_TAG == ''
use_compute_credits: $CIRRUS_USER_COLLABORATOR == 'true'
osx_instance:
image: catalina-xcode-11.3.1-flutter
upgrade_script:
- sudo gem install cocoapods
- flutter channel stable
- flutter upgrade
- flutter channel master
- flutter upgrade
- git fetch origin master
create_simulator_script:
- xcrun simctl list
- xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-X com.apple.CoreSimulator.SimRuntime.iOS-13-3 | xargs xcrun simctl boot
matrix:
- name: lint_darwin_plugins
env:
matrix:
Expand Down
1 change: 1 addition & 0 deletions script/tool/lib/src/lint_podspecs_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ class LintPodspecsCommand extends PluginCommand {
'lib',
'lint',
podspecPath,
'--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices.
if (allowWarnings) '--allow-warnings',
if (libraryLint) '--use-libraries'
];
Expand Down
4 changes: 4 additions & 0 deletions script/tool/test/lint_podspecs_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ void main() {
'lib',
'lint',
p.join(plugin1Dir.path, 'ios', 'plugin1.podspec'),
'--configuration=Debug',
'--use-libraries'
],
mockPackagesDir.path),
Expand All @@ -90,6 +91,7 @@ void main() {
'lib',
'lint',
p.join(plugin1Dir.path, 'ios', 'plugin1.podspec'),
'--configuration=Debug',
],
mockPackagesDir.path),
]),
Expand Down Expand Up @@ -138,6 +140,7 @@ void main() {
'lib',
'lint',
p.join(plugin1Dir.path, 'plugin1.podspec'),
'--configuration=Debug',
'--allow-warnings',
'--use-libraries'
],
Expand All @@ -148,6 +151,7 @@ void main() {
'lib',
'lint',
p.join(plugin1Dir.path, 'plugin1.podspec'),
'--configuration=Debug',
'--allow-warnings',
],
mockPackagesDir.path),
Expand Down