Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Adopt Xcode 12 for podspec lints #3653

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Mar 2, 2021

Adopt Xcode 12 for all Cirrus tasks.
Add --configuration=Debug option (available as of CocoaPods 1.10) to pod lib lint CI script so the build only targets the supported x86_64 simulator, not the unsupported (by Flutter) arm64 simulator.

See also #3304.

@jmagman
Copy link
Member Author

jmagman commented Mar 2, 2021

Well that didn't work. Turns out that new --configuration flag doesn't work for --analyze. I guess this will have to wait until my PR CocoaPods/CocoaPods#10477 is merged and lands in a CocoaPods release.

@jmagman
Copy link
Member Author

jmagman commented Mar 3, 2021

Well that didn't work. Turns out that new --configuration flag doesn't work for --analyze. I guess this will have to wait until my PR CocoaPods/CocoaPods#10477 is merged and lands in a CocoaPods release.

Actually I just removed the analyzer from the pod lib lint in #3667. Will rebase on that once it lands.

@jmagman
Copy link
Member Author

jmagman commented Mar 3, 2021

@jmagman jmagman requested a review from cyanglaz March 3, 2021 04:58
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is great! Thank you!

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 3, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite submit-queue has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 3, 2021
@jmagman jmagman merged commit 025c8c1 into flutter:master Mar 3, 2021
@jmagman jmagman deleted the xcode-12 branch March 3, 2021 18:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Mar 3, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull request Mar 3, 2021
* master:
  Adopt Xcode 12 for podspec lints (flutter#3653)
  Run static analyzer during xctest (flutter#3667)
  [google_maps_flutter_web] update min flutter sdk version to 1.20.0 (flutter#3662)
  [image_picker] Run CocoaPods iOS tests in RunnerUITests target (flutter#3663)
  [webview_flutter] Run CocoaPods iOS tests in RunnerUITests target (flutter#3664)
  [device_info] Enable NNBD for unit test (flutter#3658)
  remove unused plugin (flutter#3661)
  [android_intent] move unit test to nullsafety (flutter#3659)
  [url_launcher] Migrate unit tests to NNBD (flutter#3657)
  [share] Migrate unit tests to null-safety. (flutter#3660)
  [connectivity_for_web] Migration to null-safety. (flutter#3652)
  [camera] Stable release for null safety. (flutter#3641)
  [in_app_purchase] fix plugin version (flutter#3654)
  Move plugin tool tests over (flutter#3606)
  [in_app_purchase] migrate playing billing library to v3 (flutter#3636)
  Update plugin_platform_interface min version (flutter#3650)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants