This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Run CocoaPods iOS tests in RunnerUITests target #3663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
force-pushed
the
image-picker-tests
branch
2 times, most recently
from
18c4c30 to
19dc6ca
Compare
jmagman
commented
Mar 2, 2021
Comment on lines
+33
to
+35
| target 'RunnerUITests' do | ||
| inherit! :search_paths | ||
| end |
There was a problem hiding this comment.
Checked in the Podfile to inherit search_paths so Flutter linker flags are hooked up. See #3145 for similar fix.
jmagman
force-pushed
the
image-picker-tests
branch
from
19dc6ca to
fc5740c
Compare
cyanglaz
reviewed
Mar 2, 2021
You can run whatever you want in the UI tests as long as the symbols are available. The It worked: |
2 tasks
cyanglaz
approved these changes
Mar 3, 2021
Sure, we can use whatever test target name we want once #3667 merges. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Mar 3, 2021
* master: Adopt Xcode 12 for podspec lints (flutter#3653) Run static analyzer during xctest (flutter#3667) [google_maps_flutter_web] update min flutter sdk version to 1.20.0 (flutter#3662) [image_picker] Run CocoaPods iOS tests in RunnerUITests target (flutter#3663) [webview_flutter] Run CocoaPods iOS tests in RunnerUITests target (flutter#3664) [device_info] Enable NNBD for unit test (flutter#3658) remove unused plugin (flutter#3661) [android_intent] move unit test to nullsafety (flutter#3659) [url_launcher] Migrate unit tests to NNBD (flutter#3657) [share] Migrate unit tests to null-safety. (flutter#3660) [connectivity_for_web] Migration to null-safety. (flutter#3652) [camera] Stable release for null safety. (flutter#3641) [in_app_purchase] fix plugin version (flutter#3654) Move plugin tool tests over (flutter#3606) [in_app_purchase] migrate playing billing library to v3 (flutter#3636) Update plugin_platform_interface min version (flutter#3650) # Conflicts: # packages/webview_flutter/CHANGELOG.md # packages/webview_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pod lib linthas been used to run iOS unit tests and the static analyzer. Unfortunately due to Flutter not supporting ARM iOS simulators and the fact that we can't tell thepodcommand to skip analyzing on that architecture, this has prevented the plugins CI from migrating to Xcode 12 and is blocking Flutter from increasing the Xcode minimum version to 12.Now that we have a full-fledged xctest_command we can migrate some of the value we were getting from
pod lib lint.Migrate
image_pickerpackage to run all the unit tests as part of theRunnerUITeststarget. Remove the oldimage_picker_exampleTestsin favor ofRunnerUITests.Also swap
VALID_ARCHSto the Xcode 12EXCLUDED_ARCHSgenerated by the Flutter template as of flutter/flutter#64504