Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[android_intent] move unit test to nullsafety #3659

Merged
merged 2 commits into from
Mar 2, 2021
Merged

[android_intent] move unit test to nullsafety #3659

merged 2 commits into from
Mar 2, 2021

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Mar 2, 2021 •
edited
Loading

Used mockito's code gen to generate mocks.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@cyanglaz cyanglaz requested a review from stuartmorgan-g March 2, 2021 19:20
stuartmorgan-g
stuartmorgan-g approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the output isn't too terrible. How was the experience of using it?

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Mar 2, 2021

@stuartmorgan it's pretty straight forward. Also i was able to keep the tests mostly intact.

@stuartmorgan-g
Copy link
Contributor

Thanks for giving it a test drive :) Looks like this is probably the cleaner solution for anything that's doing more than simple faking (e.g., my last PR would probably have been better off this way)

@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 2, 2021
@fluttergithubbot fluttergithubbot merged commit beef9a8 into flutter:master Mar 2, 2021
@cyanglaz cyanglaz deleted the nnbd_test branch March 2, 2021 22:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2021
@engine-flutter-autoroll
beef9a8 [android_intent] move unit test to nullsafety (flutter/plugin…
1374057 
…s#3659)
NickalasB added a commit to NickalasB/plugins that referenced this pull request Mar 3, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
a0e64b5 
* master:
  Adopt Xcode 12 for podspec lints (flutter#3653)
  Run static analyzer during xctest (flutter#3667)
  [google_maps_flutter_web] update min flutter sdk version to 1.20.0 (flutter#3662)
  [image_picker] Run CocoaPods iOS tests in RunnerUITests target (flutter#3663)
  [webview_flutter] Run CocoaPods iOS tests in RunnerUITests target (flutter#3664)
  [device_info] Enable NNBD for unit test (flutter#3658)
  remove unused plugin (flutter#3661)
  [android_intent] move unit test to nullsafety (flutter#3659)
  [url_launcher] Migrate unit tests to NNBD (flutter#3657)
  [share] Migrate unit tests to null-safety. (flutter#3660)
  [connectivity_for_web] Migration to null-safety. (flutter#3652)
  [camera] Stable release for null safety. (flutter#3641)
  [in_app_purchase] fix plugin version (flutter#3654)
  Move plugin tool tests over (flutter#3606)
  [in_app_purchase] migrate playing billing library to v3 (flutter#3636)
  Update plugin_platform_interface min version (flutter#3650)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
#	packages/webview_flutter/example/ios/Runner.xcodeproj/project.pbxproj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes p: android_intent waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyanglaz @stuartmorgan-g @ditman @fluttergithubbot