[image_picker_for_web] Migrate image_picker to package:cross_file #4083

BeMacized · 2021-06-23T08:53:43Z

Changed all usages of PickedFile to XFile, to follow the changes made to the platform interface (#4072)

This PR will remain in draft state until the platform interface changes have been merged and published (#4072), so that the pubspec can be updated properly.

Relevant issue:

[image_picker] Migrate image_picker to package:cross_file flutter#70886

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…nce it gets published.

ditman · 2021-07-09T00:09:00Z

Let's go! The platform_interface has been published here:

https://pub.dev/packages/image_picker_platform_interface/changelog#220

ditman · 2021-07-09T01:01:36Z

@BeMacized, I've brought the branch up to date with the latest master, removed the "deprecated" methods (let's add those only in the core plugin package), and used this opportunity to migrate the tests to run with flutter drive, instead of flutter test --platform=chrome (part of flutter/flutter#81982).

There's documentation linked in the new README files, but TL;DR, this is how tests can be run now:

Ensure chromedriver --port=4444 is running
From the root of the repo, run: dart ./script/tool/lib/src/main.dart drive-examples --packages=image_picker/image_picker_for_web --web.

And this is the output:

dit@dit:~/github/plugins$ dart ./script/tool/lib/src/main.dart drive-examples --packages=image_picker/image_picker_for_web --web
script/tool/lib/src/main.dart: Warning: Interpreting this as package URI, 'package:flutter_plugin_tools/src/main.dart'.

============================================================
|| Running for image_picker_for_web
============================================================

Running command: "flutter drive -d web-server --web-port=7357 --browser-name=chrome --driver test_driver/integration_test.dart --target integration_test/image_picker_for_web_test.dart" in /usr/local/google/home/dit/github/plugins/packages/image_picker/image_picker_for_web/example
Running "flutter pub get" in example...                            614ms
Launching integration_test/image_picker_for_web_test.dart on Web Server in debug mode...
Waiting for connection from debug service on Web Server...         16.6s
integration_test/image_picker_for_web_test.dart is being served at http://localhost:7357
The web-server device requires the Dart Debug Chrome extension for debugging. Consider using the Chrome or Edge devices for an improved development workflow.
Application finished.
[WARNING]: http://localhost:7357/dart_sdk.js 48732:16 "registerExtension() from dart:developer is only supported in build/run/test environments where the developer event method hooks have been set."
[WARNING]: http://localhost:7357/dart_sdk.js 48714:16 "postEvent() from dart:developer is only supported in build/run/test environments where the developer event method hooks have been set."
[INFO]: http://localhost:7357/dart_sdk.js 27220:14 "00:00 +0: Can select a file (Deprecated)"
[WARNING]: http://localhost:7357/packages/image_picker_for_web/image_picker_for_web.dart.js 204 File chooser dialog can only be shown with a user activation.
[INFO]: http://localhost:7357/dart_sdk.js 27220:14 "00:00 +1: Can select a file"
[WARNING]: http://localhost:7357/packages/image_picker_for_web/image_picker_for_web.dart.js 204 File chooser dialog can only be shown with a user activation.
[INFO]: http://localhost:7357/dart_sdk.js 27220:14 "00:00 +2: computeCaptureAttribute"
[INFO]: http://localhost:7357/dart_sdk.js 27220:14 "00:00 +3: createInputElement accept: any, capture: null"
[INFO]: http://localhost:7357/dart_sdk.js 27220:14 "00:00 +4: createInputElement accept: any, capture: something"
[INFO]: http://localhost:7357/dart_sdk.js 27220:14 "00:00 +5: (tearDownAll)"
[INFO]: http://localhost:7357/dart_sdk.js 27220:14 "00:00 +6: All tests passed!"
All tests passed.


------------------------------------------------------------
Run overview:
  image_picker_for_web - ran

Ran for 1 package(s)


No issues found!

Let me know if you can run the tests (or not!) and if the code changes make sense to you! Then we can wrap this up and get it ready to be merged!

ditman · 2021-07-09T01:33:27Z

Just verified that tests are running in CI. See this run, for example.

BeMacized · 2021-07-09T07:28:27Z

@ditman Alright! I can confirm the tests succeed locally as well, so I've marked this PR as ready for review.

ditman · 2021-07-09T18:18:23Z

packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart

+      final objectUrl = _handleOnChangeEvent(event);
+      if (!_completer.isCompleted && objectUrl != null) {
+        _completer.complete(XFile(objectUrl));
+      }


Let's extract the name on disk of the file from this event so we can initialize the XFile with it! (to fix flutter/flutter#58764)

There's an example of it here: https://github.com/flutter/plugins/blob/master/packages/file_selector/file_selector_web/lib/src/dom_helper.dart#L59-L66

ditman

We'll leave the name/length extraction for v2.1.1, so we can finish this migration without too much feature creep.

…file (flutter/plugins#4083)

…file (flutter/plugins#4083) (#86207)

ditman · 2021-07-10T00:35:59Z

Published https://pub.dev/packages/image_picker_for_web/changelog#210

…utter#4083) * Migrate image picker platform interface to cross_file * Port tests from --platform=chrome to integration_test Co-authored-by: David Iglesias Teixeira <[email protected]>

* upstream_master: (40 commits) [image_picker] Image picker fix camera device (flutter#3898) [flutter_plugin_tools] Improve license-check output (flutter#4154) [webview_flutter] Fix broken keyboard issue link (flutter#3266) [flutter_plugin_tools] Support format on Windows (flutter#4150) [flutter_plugin_tools] Make unit tests pass on Windows (flutter#4149) [image_picker_for_web] Migrate image_picker to package:cross_file (flutter#4083) [various] Prepare plugin repo for binding API improvements (flutter#4148) [quick_actions] Add const constructor (flutter#4131) [in_app_purchase] Add iOS currency symbol to ProductDetails (flutter#4144) [in_app_purchase] Added priceCurrencySymbol to SkuDetailsWrapper (flutter#4114) [image_picker_platform_interface] Add methods that return package:cross_file (flutter#4072) [flutter_plugin_tools] Improve and test 'format' (flutter#4145) [flutter_plugin_tools] Only check target packages in analyze (flutter#4146) [in_app_purchase] Fix crash when retrieveReceiptWithError gives an error. (flutter#4138) [video_player] Pause video when it completes (flutter#3727) [in_app_purchase] Add currencySymbol to ProductDetails (flutter#4115) [in_app_purchase] Add documentation for price change confirmations (flutter#4092) [camera] android-rework part 8: Supporting modules for final implementation (flutter#4054) [plugin_platform_interface] Fix README broken link (flutter#4143) [various] Prepare plugin repo for binding API improvements (flutter#4137) ...

…utter#4083) * Migrate image picker platform interface to cross_file * Port tests from --platform=chrome to integration_test Co-authored-by: David Iglesias Teixeira <[email protected]>

BeMacized added 2 commits June 21, 2021 14:51

Migrate image picker platform interface to cross_file

4b3c599

[image_picker_for_web] Migration to cross_file

f4fbd0c

BeMacized requested a review from ditman June 23, 2021 08:53

google-cla bot added the cla: yes label Jun 23, 2021

github-actions bot added p: image_picker platform-web labels Jun 23, 2021

This was referenced Jun 23, 2021

[image_picker_platform_interface] Migrate image_picker to package:cross_file #4072

Merged

[image_picker] Migrate image_picker to package:cross_file #4073

Merged

BeMacized and others added 16 commits June 30, 2021 15:45

Merge branch 'master' into issue/70886

2de19b4

Merge branch 'issue/70886' into issue/70886-impl-web

86f604b

Re-added old methods and marked them as deprecated.

68e2ef8

Merge branch 'issue/70886' into issue/70886-impl-web

d345b37

Update to match platform interface changes

a0ab00e

Format & annotate deprecated classes.

a987170

Merge branch 'issue/70886' into issue/70886-impl-web

6ab2bb0

Updated pubspec and changelog.

3fa10b9

Merge branch 'issue/70886' into issue/70886-impl-web

c1ff8b2

Updated platform interface dependency version

addfe99

Updated changelog and pubspec version

aefff73

Fix analysis issues for deprecations

2c4cd91

Merge branch 'issue/70886' into issue/70886-impl-web

69969b2

Remove Deprecation tags so we don't break consumers of this package o…

29e0c40

…nce it gets published.

Merge branch 'master' into issue/70886

c74cebb

Merge branch 'issue/70886' into issue/70886-impl-web

0a082c8

This comment has been minimized.

Sign in to view

google-cla bot added cla: no and removed cla: yes labels Jul 8, 2021

Temporary platform interface reference dependency

4615db1

This comment has been minimized.

Sign in to view

Implement PR feedback

faa1a99

Merge branch 'issue/70886' into issue/70886-impl-web

afa61ab

This comment has been minimized.

Sign in to view

ditman added 4 commits July 8, 2021 17:13

Merge branch 'master' into issue/70886-impl-web

e297f3f

Depend on the published version of the platform interface

60c2ffd

Remove Deprecated methods, so consumers don't break immediately.

5e7abfd

Port tests from --platform=chrome to integration_test

de50d56

This comment has been minimized.

Sign in to view

google-cla bot added cla: yes and removed cla: no labels Jul 9, 2021

dart format

b01daeb

BeMacized marked this pull request as ready for review July 9, 2021 07:24

BeMacized requested a review from cyanglaz as a code owner July 9, 2021 07:24

ditman reviewed Jul 9, 2021

View reviewed changes

ditman approved these changes Jul 9, 2021

View reviewed changes

ditman merged commit 731b93d into flutter:master Jul 9, 2021

engine-flutter-autoroll mentioned this pull request Jul 9, 2021

Roll Plugins from 8a966ebfdca4 to 731b93d52e79 (1 revision) flutter/flutter#86207

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 9, 2021

731b93d [image_picker_for_web] Migrate image_picker to package:cross_…

fa96378

…file (flutter/plugins#4083)

fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jul 10, 2021

731b93d [image_picker_for_web] Migrate image_picker to package:cross_…

141ca1e

…file (flutter/plugins#4083) (#86207)

mvanbeusekom deleted the issue/70886-impl-web branch September 21, 2021 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[image_picker_for_web] Migrate image_picker to package:cross_file #4083

[image_picker_for_web] Migrate image_picker to package:cross_file #4083

BeMacized commented Jun 23, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ditman commented Jul 9, 2021

This comment has been minimized.

This comment has been minimized.

ditman commented Jul 9, 2021 •

edited

Loading

ditman commented Jul 9, 2021

BeMacized commented Jul 9, 2021

ditman Jul 9, 2021 •

edited

Loading

ditman Jul 9, 2021

ditman left a comment •

edited

Loading

ditman commented Jul 10, 2021

[image_picker_for_web] Migrate image_picker to package:cross_file #4083

[image_picker_for_web] Migrate image_picker to package:cross_file #4083

Conversation

BeMacized commented Jun 23, 2021

Pre-launch Checklist

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ditman commented Jul 9, 2021

This comment has been minimized.

This comment has been minimized.

ditman commented Jul 9, 2021 • edited Loading

ditman commented Jul 9, 2021

BeMacized commented Jul 9, 2021

ditman Jul 9, 2021 • edited Loading

Choose a reason for hiding this comment

ditman Jul 9, 2021

Choose a reason for hiding this comment

ditman left a comment • edited Loading

Choose a reason for hiding this comment

ditman commented Jul 10, 2021

ditman commented Jul 9, 2021 •

edited

Loading

ditman Jul 9, 2021 •

edited

Loading

ditman left a comment •

edited

Loading