This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Add documentation for price change confirmations #4092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
suggested changes
Jun 28, 2021
Co-authored-by: Maurits van Beusekom <[email protected]>
renefloor
changed the title
renefloor
commented
Jun 29, 2021
Comment on lines
463
to
467
| if (priceChangeConfirmationResult.responseCode == BillingResponse.ok) { | ||
| // TODO acknowledge price change | ||
| } else { | ||
| // TODO show error | ||
| } |
There was a problem hiding this comment.
@mvanbeusekom I'm not sure what to do here. Should I just add a print statement, leave these todo's or do you have an idea?
There was a problem hiding this comment.
Maybe we can simply show a snackbar message confirming the price change or showing the error?
mvanbeusekom
reviewed
Jul 7, 2021
Comment on lines
463
to
467
| if (priceChangeConfirmationResult.responseCode == BillingResponse.ok) { | ||
| // TODO acknowledge price change | ||
| } else { | ||
| // TODO show error | ||
| } |
There was a problem hiding this comment.
Maybe we can simply show a snackbar message confirming the price change or showing the error?
|
@mvanbeusekom I also added the code that actually calls the price change function: 4b62107#diff-4a28c57f2e830b968dfb575e9152d91d12d3d276641696552e79df589daa1291L261-R263 |
mvanbeusekom
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 8, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 8, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Jul 10, 2021
Ralph-Li
added a commit
to Insight-Timer/plugins
that referenced
this pull request
Jul 15, 2021
* upstream_master: (40 commits) [image_picker] Image picker fix camera device (flutter#3898) [flutter_plugin_tools] Improve license-check output (flutter#4154) [webview_flutter] Fix broken keyboard issue link (flutter#3266) [flutter_plugin_tools] Support format on Windows (flutter#4150) [flutter_plugin_tools] Make unit tests pass on Windows (flutter#4149) [image_picker_for_web] Migrate image_picker to package:cross_file (flutter#4083) [various] Prepare plugin repo for binding API improvements (flutter#4148) [quick_actions] Add const constructor (flutter#4131) [in_app_purchase] Add iOS currency symbol to ProductDetails (flutter#4144) [in_app_purchase] Added priceCurrencySymbol to SkuDetailsWrapper (flutter#4114) [image_picker_platform_interface] Add methods that return package:cross_file (flutter#4072) [flutter_plugin_tools] Improve and test 'format' (flutter#4145) [flutter_plugin_tools] Only check target packages in analyze (flutter#4146) [in_app_purchase] Fix crash when retrieveReceiptWithError gives an error. (flutter#4138) [video_player] Pause video when it completes (flutter#3727) [in_app_purchase] Add currencySymbol to ProductDetails (flutter#4115) [in_app_purchase] Add documentation for price change confirmations (flutter#4092) [camera] android-rework part 8: Supporting modules for final implementation (flutter#4054) [plugin_platform_interface] Fix README broken link (flutter#4143) [various] Prepare plugin repo for binding API improvements (flutter#4137) ...
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android and iOS plugins for in_app_purchase added features to handle price change confirmations. This PR adds the explanation to the readme of the generic package.
This PR is a WIP/Draft as the iOS feature is not completely finished yet.
Android: PR #4077 and issue flutter/flutter#85038
iOS PR #4085 and issue flutter/flutter#85129
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.