Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[file-selector] Update iOS example to use the proper properties when filtering files. #6453

Closed
wants to merge 1 commit into from

Conversation

juandausa
Copy link
Contributor

Update iOS samples:

  • Remove label and extensions which are dismissed in the current code. This way, the sample shows the actual mandatory parameters.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@juandausa juandausa requested a review from jmagman as a code owner September 19, 2022 11:50
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@juandausa juandausa force-pushed the 103743-update-ios-sample branch from 4a99e46 to 9691f91 Compare September 19, 2022 12:59
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission, but implementation package examples are primarily for our own testing purposes; plugin clients should use the app-facing package and its examples. We deliberately use the same examples across implementation packages unless there's a compelling reason to change them.

Separately from that, someone using file_selector only with macOS is extremely unlikely, so these changes are likely to do more harm than good.

@juandausa juandausa deleted the 103743-update-ios-sample branch September 19, 2022 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants