Enable Mac ios_platform_tests tests #6682

keyonghan · 2022-11-09T00:52:21Z

keyonghan · 2022-11-12T00:09:40Z

All master shards passed, but two of four stable shards failed complaining about identifiers:

'com.apple.platform.appletvos' is an unknown platform identifier
'com.apple.platform.watchos' is an unknown platform identifier

Examples:
Mac_x64 ios_platform_tests_0_4 stable
Mac_x64 ios_platform_tests_2_4 stable

/cc @stuartmorgan Do you see anything we missed in this PR?

keyonghan · 2022-11-12T00:10:22Z

.ci/scripts/create_simulator.sh

+# found in the LICENSE file.
+
+xcrun simctl list
+xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-16-0 | xargs xcrun simctl boot


Updated to use iOS-16-0, which is the default runtime with current xcode.

stuartmorgan-g

LGTM with some minor nits.

stuartmorgan-g · 2022-11-14T14:19:39Z

.ci.yaml

+  # TODO(stuartmorgan): Swap this and ios-build_all_plugins once simulator
+  # tests are reliable on the ARM infrastructure. See discussion at
+  # https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
+  - name: Max_x64 ios_platform_tests_0_4 master


Without the clarify of "index" and "count" being in the name, I think it would be clear to 1-index them and add an "of". I.e., ios_platform_tests_1_of_4 through ios_platform_tests_4_of_4.

stuartmorgan-g · 2022-11-14T14:21:33Z

.ci/scripts/create_simulator.sh

+# found in the LICENSE file.
+
+xcrun simctl list
+xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-16-0 | xargs xcrun simctl boot


Since we have a mini-script, I think it would be nice to pull out the device and OS into variables so each is on their own line instead of one massive line.

SG. Updated the script.

stuartmorgan-g · 2022-11-14T14:24:48Z

.ci.yaml

+  # TODO(stuartmorgan): Swap this and ios-build_all_plugins once simulator
+  # tests are reliable on the ARM infrastructure. See discussion at
+  # https://github.com/flutter/plugins/pull/5693#issuecomment-1126011089
+  - name: Max_x64 ios_platform_tests_0_4 master


Is there any plan to building matricies into Cocoon? Having to specify each of these explicitly is much more verbose and error prone than the Cirrus matrix spec. It would also be a huge pain to change the sharding (which we do occasionally) since instead of being able to do a single PR—including the ability to iterate in presubmit to see what the best number of shards is, which is usually what we have done in the past—we'll need to add a whole duplicate set in bringup, land them, see how they go, iterate in post-submit with new PRs if necessary, and then finally do a last PR to switch over.

A generic builder will do the trick. It has been planned for release branches (flutter/flutter#97265), and we can do the same for main/master.
But currently it is blocked on LUCI team implementing the support API. Once that's unblocked, we should be able to use cocoon do the scheduling.

* 79d62f726 Roll Flutter from 5ea5a53 to a1289a4 (7 revisions) (flutter/plugins#6677) * 910b61d1b Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter/plugins#6681) * 58579201e Roll Flutter from a1432a9 to d3dcd7d (8 revisions) (flutter/plugins#6684) * 6da73be00 Enable `Mac build_all_plugins` (flutter/plugins#6671) * cc4ffaebd Update flutter cirrus key (flutter/plugins#6687) * f35c16930 Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter/plugins#6689) * 553dac8b2 Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter/plugins#6692) * 11cb48366 Roll Flutter (stable) from e99c9c7 to 52b3dc2 (4 revisions) (flutter/plugins#6690) * b1c457fc9 Roll Flutter from 098aac7 to 61e927d (16 revisions) (flutter/plugins#6694) * e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)

cyanglaz · 2022-11-17T02:14:44Z

The [Mac_x64 ios_platform_tests_2_of_4 master](https://ci.chromium.org/p/flutter/builders/staging/Mac_x64%20ios_platform_tests_2_of_4%20master) kept failing post submit

keyonghan · 2022-11-17T17:58:08Z

The [Mac_x64 ios_platform_tests_2_of_4 master](https://ci.chromium.org/p/flutter/builders/staging/Mac_x64%20ios_platform_tests_2_of_4%20master) kept failing post submit

They are marked as bringup: true and should not block the tree. Now the tree is green: flutter/flutter#115534

* add 0_4 master * typo fix * update args * fix args * ios runtime update * name change & variables * platform name fix

…r#115366) * 79d62f726 Roll Flutter from 5ea5a53 to a1289a4 (7 revisions) (flutter/plugins#6677) * 910b61d1b Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter/plugins#6681) * 58579201e Roll Flutter from a1432a9 to d3dcd7d (8 revisions) (flutter/plugins#6684) * 6da73be00 Enable `Mac build_all_plugins` (flutter/plugins#6671) * cc4ffaebd Update flutter cirrus key (flutter/plugins#6687) * f35c16930 Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter/plugins#6689) * 553dac8b2 Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter/plugins#6692) * 11cb48366 Roll Flutter (stable) from e99c9c7 to 52b3dc2 (4 revisions) (flutter/plugins#6690) * b1c457fc9 Roll Flutter from 098aac7 to 61e927d (16 revisions) (flutter/plugins#6694) * e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)

* add 0_4 master * typo fix * update args * fix args * ios runtime update * name change & variables * platform name fix

keyonghan marked this pull request as draft November 9, 2022 00:52

keyonghan commented Nov 12, 2022

View reviewed changes

keyonghan requested review from godofredoc and stuartmorgan-g November 12, 2022 00:11

keyonghan marked this pull request as ready for review November 12, 2022 00:11

keyonghan added 5 commits November 11, 2022 16:14

add 0_4 master

c3ec25d

typo fix

bb597aa

update args

f7e09fb

fix args

9ebdc82

ios runtime update

bea4b96

keyonghan force-pushed the ios_platform_tests branch from 88bb22f to bea4b96 Compare November 12, 2022 00:16

stuartmorgan-g approved these changes Nov 14, 2022

View reviewed changes

keyonghan added 2 commits November 14, 2022 13:37

name change & variables

9735b75

platform name fix

38362ea

keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 15, 2022

auto-submit bot merged commit e500884 into flutter:main Nov 15, 2022

engine-flutter-autoroll mentioned this pull request Nov 15, 2022

Roll Plugins from 3ca34103db0f to e500884c758c (10 revisions) flutter/flutter#115366

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022

e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)

b10c98f

This was referenced Nov 17, 2022

Migrate flutter/packages Cirrus tasks to LUCI flutter/flutter#114373

Closed

Plugins ios_platform_tests takes >1h to run for each shard flutter/flutter#115596

Closed

adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022

Enable Mac ios_platform_tests tests (flutter#6682)

0796975

* add 0_4 master * typo fix * update args * fix args * ios runtime update * name change & variables * platform name fix

keyonghan mentioned this pull request Nov 21, 2022

Switch ios_platform_tests from Cirrus to LUCI #6729

Merged

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

Enable Mac ios_platform_tests tests (flutter#6682)

220d5b5

* add 0_4 master * typo fix * update args * fix args * ios runtime update * name change & variables * platform name fix

stuartmorgan-g mentioned this pull request Apr 20, 2023

[pigeon] Add an initial example app flutter/packages#3761

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Mac ios_platform_tests tests #6682

Enable Mac ios_platform_tests tests #6682

keyonghan commented Nov 9, 2022

keyonghan commented Nov 12, 2022

keyonghan Nov 12, 2022

stuartmorgan-g left a comment

stuartmorgan-g Nov 14, 2022

keyonghan Nov 14, 2022

stuartmorgan-g Nov 14, 2022

keyonghan Nov 14, 2022

stuartmorgan-g Nov 14, 2022

keyonghan Nov 14, 2022

cyanglaz commented Nov 17, 2022 •

edited

Loading

keyonghan commented Nov 17, 2022

Enable Mac ios_platform_tests tests #6682

Enable Mac ios_platform_tests tests #6682

Conversation

keyonghan commented Nov 9, 2022

keyonghan commented Nov 12, 2022

keyonghan Nov 12, 2022

Choose a reason for hiding this comment

stuartmorgan-g left a comment

Choose a reason for hiding this comment

stuartmorgan-g Nov 14, 2022

Choose a reason for hiding this comment

keyonghan Nov 14, 2022

Choose a reason for hiding this comment

stuartmorgan-g Nov 14, 2022

Choose a reason for hiding this comment

keyonghan Nov 14, 2022

Choose a reason for hiding this comment

stuartmorgan-g Nov 14, 2022

Choose a reason for hiding this comment

keyonghan Nov 14, 2022

Choose a reason for hiding this comment

cyanglaz commented Nov 17, 2022 • edited Loading

keyonghan commented Nov 17, 2022

cyanglaz commented Nov 17, 2022 •

edited

Loading