-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Switch ios_platform_tests
from Cirrus to LUCI
#6729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could you do a quick change to mirror the recent changes you've made to the plugins recipe (script arguments, sharding env variable, etc.) to the packages repo recipe? I'm actively working on synchronizing the flutter/plugins and flutter/packages CI in preparation for the repo merge, and realized that I can't spin up these new LUCI tests there without recipe changes.
Sure. Script args support: https://flutter-review.git.corp.google.com/c/recipes/+/36541. |
Seems the tree is closed. Is there a bug tracking it? Let me know if you need a bug to track /cc @stuartmorgan |
Looks like it's open now; there may have been a flaky failure. |
* move to prod * remove cirrus
* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
…#115930) * 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
…#115930) * 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
* move to prod * remove cirrus
Follow up of #6682 to switch
ios_platform_tests
from Cirrus to LUCI completely.These tasks are running green consistently:

Part of flutter/flutter#114373