This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera][google_maps_flutter][path_provider] prepare for TestDefaultBinaryMessengerBinding.instance becoming non-nullable #6847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
added
override: no versioning needed
Hixie
requested review from
cbracken,
cyanglaz,
hellohuanlin,
GaryQian,
camsim99 and
stuartmorgan-g
as code owners
| // This should be removed once the relevant changes makes it to stable. | ||
| // TODO(ianh): look into this in Q2 2023. | ||
| T _ambiguate<T extends Object>(T? value) { | ||
| return value!; |
There was a problem hiding this comment.
Is it intentional that this is the reverse of what we did last time? We did T->T? and then kept the ! at the call site before, which seems more explicit about what's happening at the call site. If we want this behavior instead I think we should call this something that sounds dangerous, since it's force-unwrapping (e.g., _forceUnwrapIfNullable).
There was a problem hiding this comment.
@Hixie Ping on this question.
There was a problem hiding this comment.
no, definitely not intentional. i'll reverse it.
Hixie
force-pushed
the
TestDefaultBinaryMessengerBinding
branch
from
82876ba to
2787cf0
Compare
github-actions
bot
added
p: url_launcher
p: video_player
and removed
platform-macos
p: path_provider
labels
Hixie
force-pushed
the
TestDefaultBinaryMessengerBinding
branch
from
2787cf0 to
622d354
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2023
* 8f83dc29b [various] Standardize the extension for Pigeon-generated Dart (flutter/plugins#7029) * 8fcff8756 Roll Flutter from 75680ae to 0a22a1d (3 revisions) (flutter/plugins#7051) * 3d81a0071 [tool] More main-branch detection improvement (flutter/plugins#7067) * e41f9f95e [ci] Clean up analysis options (flutter/plugins#7068) * 4cf6f4494 [in_app_puchase_storekit] handle `appStoreReceiptURL` is nil (flutter/plugins#7069) * d5bab1668 prepare for TestDefaultBinaryMessengerBinding.instance becoming non-nullable (flutter/plugins#6847) * 36d8066cf Roll Flutter from 0a22a1d to d278808 (58 revisions) (flutter/plugins#7078) * ec463866f [various] prepare for more const widgets (flutter/plugins#7074) * dbf8d8d07 Change google_sign_in_ios and image_picker_ios owners (flutter/plugins#7070) * 1d4570bb0 Update README.md (flutter/plugins#7076) * 9302d87ee [ci] More cirrus.yml pre-alignment with flutter/packages (flutter/plugins#7079)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).