[various] prepare for more const widgets #7074
Conversation
goderbauer
requested review from
cbracken,
hellohuanlin,
camsim99 and
stuartmorgan-g
as code owners
goderbauer
force-pushed
the
moreconstignores
branch
from
2d7fbb4 to
9eaba38
Compare
| @@ -1,6 +1,7 @@ | |||
| ## NEXT | |||
|
|
|||
| * Updates minimum Flutter version to 3.0. | |||
| * Ignores a lint in the tests for backwards compatibility. | |||
There was a problem hiding this comment.
All of the changelog and version changes should be reverted; the repo tooling currently doesn't do line-by-line analysis so don't know that (non-doc) comments are exempt.
| @@ -29,8 +29,12 @@ void main() { | |||
| ) async { | |||
| // Inject two map widgets... | |||
| await tester.pumpWidget( | |||
| // TODO(goderbauer): Make this const when that's available on stable. | |||
There was a problem hiding this comment.
Could you put a version? That helps with knowing when to clean it up later; we often use language like "Make this const when this package requires Flutter 3.8 or later".
There was a problem hiding this comment.
Done using your suggested language.
stuartmorgan-g
added
override: no versioning needed
|
Overrides: linter ignores are dev-only, so exempt by repo policy. |
|
If you have a chance, could you do flutter/packages as well? We currently on analyze plugins in the flutter/flutter repo so they won't show up there, but doing it in advance will avoid the roller stopping . |
goderbauer
force-pushed
the
moreconstignores
branch
from
6386238 to
4c20747
Compare
goderbauer
force-pushed
the
moreconstignores
branch
from
4c20747 to
02ce4fd
Compare
I'm on it. |
goderbauer
added
the
autosubmit
* 8f83dc29b [various] Standardize the extension for Pigeon-generated Dart (flutter/plugins#7029) * 8fcff8756 Roll Flutter from 75680ae to 0a22a1d (3 revisions) (flutter/plugins#7051) * 3d81a0071 [tool] More main-branch detection improvement (flutter/plugins#7067) * e41f9f95e [ci] Clean up analysis options (flutter/plugins#7068) * 4cf6f4494 [in_app_puchase_storekit] handle `appStoreReceiptURL` is nil (flutter/plugins#7069) * d5bab1668 prepare for TestDefaultBinaryMessengerBinding.instance becoming non-nullable (flutter/plugins#6847) * 36d8066cf Roll Flutter from 0a22a1d to d278808 (58 revisions) (flutter/plugins#7078) * ec463866f [various] prepare for more const widgets (flutter/plugins#7074) * dbf8d8d07 Change google_sign_in_ios and image_picker_ios owners (flutter/plugins#7070) * 1d4570bb0 Update README.md (flutter/plugins#7076) * 9302d87ee [ci] More cirrus.yml pre-alignment with flutter/packages (flutter/plugins#7079)
Similar to #7030.
flutter/flutter#119673 will make a few more widgets const. This prepares the plugins repo for that change.
I chose to ignore the resulting lint for now to ensure that the plugins continue to work on older versions of Flutter. Once the change referenced above is part of the oldest Flutter version supported by the plugins, we can resolve the TODO, remove the ignore, and make the widgets in question const.