-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[local_auth] Bump intl
from ^0.17.0 to ">=0.17.0 <0.19.0"
#6848
Conversation
Thanks for the contribution! You haven’t checked off any of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review. |
Two specific notes:
|
intl
from ^0.17.0 to ">=0.17.0 <0.19.0"
Thanks for notes, I updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Didn't expect that requesting a review from you would remove the automatically added reviewers. |
@stuartmorgan @exaby73 I accidentally removed the automatically added reviewers @hellohuanlin and @camsim99 |
Sorry I missed those before, I didn't think to double-check the usage when I reviewed the first time. |
# Conflicts: # packages/local_auth/local_auth_ios/CHANGELOG.md
Thanks! Great find! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again for the PR! This just needs a secondary approval to land.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* 697c8b3ee [image_picker_ios] Pass through error message from image saving (flutter/plugins#6858) * 72f810851 [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" (flutter/plugins#6848) * acbe9b452 [gh_actions]: Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/plugins#6860) * 3d8b73bf0 [camera] Remove deprecated Optional type (flutter/plugins#6870) * c5220efae [in_app_purchase] Add support for macOS (flutter/plugins#6519) * 54fc2066d Roll Flutter from 028c6e2 to dbc9306 (11 revisions) (flutter/plugins#6849)
…#117456) * 697c8b3ee [image_picker_ios] Pass through error message from image saving (flutter/plugins#6858) * 72f810851 [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" (flutter/plugins#6848) * acbe9b452 [gh_actions]: Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/plugins#6860) * 3d8b73bf0 [camera] Remove deprecated Optional type (flutter/plugins#6870) * c5220efae [in_app_purchase] Add support for macOS (flutter/plugins#6519) * 54fc2066d Roll Flutter from 028c6e2 to dbc9306 (11 revisions) (flutter/plugins#6849)
…6848) * Update intl from 0.17.0 to 0.18.0 * [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" * [local_auth] improve changelog description * [local_auth] improve changelog description * [local_auth] removes unused `intl` dependency
Because local_auth 2.1.2 depends on intl ^0.17.0 and no versions of local_auth match >2.1.2 <3.0.0, local_auth ^2.1.2 requires intl ^0.17.0.
So, because xxxxxx depends on both intl ^0.18.0 and local_auth ^2.1.2, version solving failed.
pub get failed (1; So, because xxxxxx depends on both intl ^0.18.0 and local_auth ^2.1.2, version solving failed.)
#117136
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.