Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Bump intl from ^0.17.0 to ">=0.17.0 <0.19.0" #6848

Merged
merged 6 commits into from
Dec 20, 2022

Conversation

asaarnak
Copy link
Contributor

@asaarnak asaarnak commented Dec 15, 2022

Because local_auth 2.1.2 depends on intl ^0.17.0 and no versions of local_auth match >2.1.2 <3.0.0, local_auth ^2.1.2 requires intl ^0.17.0.
So, because xxxxxx depends on both intl ^0.18.0 and local_auth ^2.1.2, version solving failed.
pub get failed (1; So, because xxxxxx depends on both intl ^0.18.0 and local_auth ^2.1.2, version solving failed.)

#117136

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! You haven’t checked off any of the items in the PR checklist above, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft December 15, 2022 14:24
@stuartmorgan-g
Copy link
Contributor

Two specific notes:

  • This needs to be done in all the sub-packages of local_auth, not just one.
  • If no code changes are needed, then this should be updated to a range that includes both 0.17 and 0.18.

@asaarnak asaarnak changed the title Update local_auth package intl dependency from 0.17.0 to 0.18.0 [local_auth] Bump intl from ^0.17.0 to ">=0.17.0 <0.19.0" Dec 15, 2022
@asaarnak
Copy link
Contributor Author

Thanks for notes, I updated the PR.
I ran tests in local_auth packages and tested example on Android.
Seems that 0.18.0 doesn't require any code changes, so we can support >=0.17.0 <0.19.0
Some Pre-launch Checklist items need more time from me to be checked, maybe tomorrow.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asaarnak asaarnak marked this pull request as ready for review December 15, 2022 18:04
@asaarnak asaarnak requested review from stuartmorgan-g and removed request for hellohuanlin and camsim99 December 15, 2022 18:09
@asaarnak
Copy link
Contributor Author

Didn't expect that requesting a review from you would remove the automatically added reviewers.

@asaarnak
Copy link
Contributor Author

@stuartmorgan @exaby73 I accidentally removed the automatically added reviewers @hellohuanlin and @camsim99

@stuartmorgan-g
Copy link
Contributor

Sorry I missed those before, I didn't think to double-check the usage when I reviewed the first time.

@asaarnak
Copy link
Contributor Author

Thanks! Great find!
PR is ready for a new review.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for the PR! This just needs a secondary approval to land.

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2022
@auto-submit auto-submit bot merged commit 72f8108 into flutter:main Dec 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 21, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 21, 2022
* 697c8b3ee [image_picker_ios] Pass through error message from image saving (flutter/plugins#6858)

* 72f810851 [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" (flutter/plugins#6848)

* acbe9b452 [gh_actions]: Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/plugins#6860)

* 3d8b73bf0 [camera] Remove deprecated Optional type (flutter/plugins#6870)

* c5220efae [in_app_purchase] Add support for macOS (flutter/plugins#6519)

* 54fc2066d Roll Flutter from 028c6e2 to dbc9306 (11 revisions) (flutter/plugins#6849)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…#117456)

* 697c8b3ee [image_picker_ios] Pass through error message from image saving (flutter/plugins#6858)

* 72f810851 [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" (flutter/plugins#6848)

* acbe9b452 [gh_actions]: Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/plugins#6860)

* 3d8b73bf0 [camera] Remove deprecated Optional type (flutter/plugins#6870)

* c5220efae [in_app_purchase] Add support for macOS (flutter/plugins#6519)

* 54fc2066d Roll Flutter from 028c6e2 to dbc9306 (11 revisions) (flutter/plugins#6849)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
…6848)

* Update intl from 0.17.0 to 0.18.0

* [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0"

* [local_auth] improve changelog description

* [local_auth] improve changelog description

* [local_auth] removes unused `intl` dependency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: local_auth platform-android platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants