[camera] Remove deprecated Optional type #6870

camsim99 · 2022-12-20T18:40:39Z

Removes deprecated Optional type from camera plugin to fix failing framework Linux_plugins test., e.g. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8794239165172938017/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/test_stdout.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-12-20T18:49:28Z

  error - example/lib/camera_controller.dart:128:33 - The argument type 'dynamic' can't be assigned to the parameter type 'DeviceOrientation?'. - argument_type_not_assignable
  error - example/lib/camera_controller.dart:130:38 - The getter 'orNull' isn't defined for the type 'DeviceOrientation'. Try importing the library that defines 'orNull', correcting the name to the name of an existing getter, or defining a getter or field named 'orNull'. - undefined_getter
  error - example/lib/camera_controller.dart:131:29 - The argument type 'dynamic' can't be assigned to the parameter type 'DeviceOrientation?'. - argument_type_not_assignable
  error - example/lib/camera_controller.dart:133:34 - The getter 'orNull' isn't defined for the type 'DeviceOrientation'. Try importing the library that defines 'orNull', correcting the name to the name of an existing getter, or defining a getter or field named 'orNull'. - undefined_getter
  error - example/lib/camera_controller.dart:135:32 - The argument type 'dynamic' can't be assigned to the parameter type 'DeviceOrientation?'. - argument_type_not_assignable
  error - example/lib/camera_controller.dart:137:37 - The getter 'orNull' isn't defined for the type 'DeviceOrientation'. Try importing the library that defines 'orNull', correcting the name to the name of an existing getter, or defining a getter or field named 'orNull'. - undefined_getter
   info - example/lib/camera_controller.dart:11:8 - Unused import: 'package:quiver/core.dart'. Try removing the import directive. - unused_import
   info - example/lib/camera_controller.dart:273:73 - Avoid redundant argument values. - avoid_redundant_argument_values
   info - example/lib/camera_controller.dart:332:29 - Avoid redundant argument values. - avoid_redundant_argument_values
   info - example/lib/camera_controller.dart:407:54 - Avoid redundant argument values. - avoid_redundant_argument_values

Are you able to see the analysis errors locally?

christopherfujino · 2022-12-20T19:16:16Z

@camsim99 FYI https://github.com/google/quiver-dart/pull/717/files, the flutter/flutter tree is unbroken. Probably still worth removing Optional (it will eventually be deprecated), but at least this isn't a tree blocker

zanderso · 2022-12-20T19:16:21Z

quiver will 3.2.1 un-deprecate Optional google/quiver-dart#717, but it will be deprecated again soon.

christopherfujino · 2022-12-20T19:57:04Z

packages/camera/camera/pubspec.yaml

@@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing
  Dart.
 repository: https://github.com/flutter/plugins/tree/main/packages/camera/camera
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
-version: 0.10.0+5
+version: 0.10.0+6


should we bump this to 0.11 since we're changing a public API?

christopherfujino

cod changes LGTM. This seems like we're changing a public API though, so I think we should bump the y part of the versions.

jmagman

LGTM

)

* 697c8b3ee [image_picker_ios] Pass through error message from image saving (flutter/plugins#6858) * 72f810851 [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" (flutter/plugins#6848) * acbe9b452 [gh_actions]: Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/plugins#6860) * 3d8b73bf0 [camera] Remove deprecated Optional type (flutter/plugins#6870) * c5220efae [in_app_purchase] Add support for macOS (flutter/plugins#6519) * 54fc2066d Roll Flutter from 028c6e2 to dbc9306 (11 revisions) (flutter/plugins#6849)

AsturaPhoenix · 2022-12-23T07:02:12Z

packages/camera/camera/lib/src/camera_controller.dart

@@ -372,9 +367,7 @@ class CameraController extends ValueNotifier<CameraValue> {
    }
    try {
      await CameraPlatform.instance.resumePreview(_cameraId);
-      value = value.copyWith(
-          isPreviewPaused: false,
-          previewPauseOrientation: const Optional<DeviceOrientation>.absent());


Unfortunately this seems to break camera orientation changes while preview is paused. Since copyWith can no longer be told to clear previewPauseOrientation, it keeps its stale value and locks the CameraPreview widget in the old orientation until the next pausePreview call.

A few of the other fields appear to be nullable as well, but I haven't looked closely to see if there are any other regressions.

Oh ok, sorry I didn't realize this. I may have to do some refactoring where Optional<DeviceOrientation> was used. Thanks for letting me know!

Removing Optional from CameraValue.copyWith caused a regression handling device orientation changes while the preview was paused. This reverts commit 3d8b73b.

This reverts commit 3d8b73b.

…#117456) * 697c8b3ee [image_picker_ios] Pass through error message from image saving (flutter/plugins#6858) * 72f810851 [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" (flutter/plugins#6848) * acbe9b452 [gh_actions]: Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/plugins#6860) * 3d8b73bf0 [camera] Remove deprecated Optional type (flutter/plugins#6870) * c5220efae [in_app_purchase] Add support for macOS (flutter/plugins#6519) * 54fc2066d Roll Flutter from 028c6e2 to dbc9306 (11 revisions) (flutter/plugins#6849)

* Remove Optional * Undo accidental order change * Fix examples analyze * Remove unused import * Bump versions * Correct version

…tions (#6911) * Add flag * Add missing comment * Add tests * Bump versions * Stage changelog changes * Revert "Fix examples analyze" This reverts commit 4db1858. * Revert "[camera] Remove deprecated Optional type (#6870)" This reverts commit 3d8b73b. * Add back optional * Edit changelog * Fix semicolon * Add )

Removing Optional from CameraValue.copyWith caused a regression handling device orientation changes while the preview was paused. This reverts commit 3d8b73b. # Conflicts: # packages/camera/camera/CHANGELOG.md # packages/camera/camera/lib/src/camera_controller.dart # packages/camera/camera/pubspec.yaml # packages/camera/camera_android/CHANGELOG.md # packages/camera/camera_android/pubspec.yaml # packages/camera/camera_avfoundation/CHANGELOG.md # packages/camera/camera_avfoundation/pubspec.yaml

Remove Optional

6b3b12b

github-actions bot added p: camera platform-android labels Dec 20, 2022

Undo accidental order change

fcf095c

camsim99 added 3 commits December 20, 2022 11:05

Fix examples analyze

4db1858

Remove unused import

af8f356

Bump versions

ff8270a

camsim99 marked this pull request as ready for review December 20, 2022 19:25

camsim99 requested review from hellohuanlin and bparrishMines as code owners December 20, 2022 19:25

camsim99 requested a review from christopherfujino December 20, 2022 19:51

christopherfujino reviewed Dec 20, 2022

View reviewed changes

christopherfujino approved these changes Dec 20, 2022

View reviewed changes

Correct version

9921e59

jmagman approved these changes Dec 20, 2022

View reviewed changes

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 20, 2022

auto-submit bot merged commit 3d8b73b into flutter:main Dec 20, 2022

engine-flutter-autoroll mentioned this pull request Dec 21, 2022

Roll Plugins from 840a04954fa0 to 54fc2066d636 (6 revisions) flutter/flutter#117456

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 21, 2022

3d8b73bf0 [camera] Remove deprecated Optional type (flutter/plugins#6870

aeda65f

)

AsturaPhoenix reviewed Dec 23, 2022

View reviewed changes

camsim99 mentioned this pull request Jan 3, 2023

[camera] Add back Optional type for nullable CameraController orientations #6911

Merged

11 tasks

camsim99 added a commit to camsim99/plugins that referenced this pull request Jan 17, 2023

Revert "[camera] Remove deprecated Optional type (flutter#6870)"

03f992c

This reverts commit 3d8b73b.

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

[camera] Remove deprecated Optional type (flutter#6870)

61955d3

* Remove Optional * Undo accidental order change * Fix examples analyze * Remove unused import * Bump versions * Correct version

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[camera] Remove deprecated Optional type #6870

[camera] Remove deprecated Optional type #6870

camsim99 commented Dec 20, 2022 •

edited

Loading

jmagman commented Dec 20, 2022

christopherfujino commented Dec 20, 2022

zanderso commented Dec 20, 2022

christopherfujino Dec 20, 2022

christopherfujino left a comment

jmagman left a comment

AsturaPhoenix Dec 23, 2022

camsim99 Dec 23, 2022

[camera] Remove deprecated Optional type #6870

[camera] Remove deprecated Optional type #6870

Conversation

camsim99 commented Dec 20, 2022 • edited Loading

Pre-launch Checklist

jmagman commented Dec 20, 2022

christopherfujino commented Dec 20, 2022

zanderso commented Dec 20, 2022

christopherfujino Dec 20, 2022

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

jmagman left a comment

Choose a reason for hiding this comment

AsturaPhoenix Dec 23, 2022

Choose a reason for hiding this comment

camsim99 Dec 23, 2022

Choose a reason for hiding this comment

camsim99 commented Dec 20, 2022 •

edited

Loading