Skip to content

ci: report recorded Garnet changes when capture is not declared complete - #115

Merged
jadoonf merged 1 commit into
mainfrom
devin/1791568452-recorded-changes-stand
Oct 9, 2026
Merged

jadoonf merged 1 commit into
mainfrom
devin/1791568452-recorded-changes-stand

Conversation

@jadoonf

@jadoonf jadoonf commented Oct 9, 2026 •

Copy link
Copy Markdown

Summary

The reviewer instructions in .coderabbit.yaml, .pr_agent.toml and pr_compliance_checklist.yaml currently say: when a record is undeterminable or its capture is not declared complete, "say it cannot support a change claim either way". No current Runtime Review record declares capture. So a reviewer following this text drops real recorded workload changes, for example +cdn.npmmirror.com −registry.npmjs.org.

This PR changes only that sentence. The new wording matches the amended shared paragraph in garnet-labs/garnet-runtime-review-mcp docs/reviewers.md, and it matches what the MCP verdict code (evaluateConsumerVerdict) already does:

undeterminable                              -> "runtime behavior for this head is unknown, never clean"
changed > 0 (capture declared or not)       -> report it; correlate with the diff
"nothing changed"                           -> only when capture is declared complete

Everything else in the three files is unchanged: the head binding, the comment-versus-description trust rule, and the untrusted-names rule.

Notes:

  • pr_compliance_checklist.yaml only takes effect after it is re-imported into the Qodo portal (Rules → Import). Qodo does not read the repo file at review time.
  • Experiment branches cut from older main still carry the old sentence in their .coderabbit.yaml, and CodeRabbit reads that file from the PR head. Pick up this change on those branches before running a reviewer-consumption test on them.

Squash Commit Body

Undeterminable means runtime behavior is unknown, never clean. An undeclared
capture only rules out a no-change claim; recorded changes stand. Matches the
amended shared paragraph in garnet-runtime-review-mcp docs/reviewers.md.

Checklist

  • Config text only; no published package changes, so no changeset.
  • .coderabbit.yaml and pr_compliance_checklist.yaml parse as YAML; .pr_agent.toml parses as TOML.

Link to Devin session: https://app.devin.ai/sessions/a14eaccd7dce45b699560a36573e4c60
Open in Devin Desktop: https://app.devin.ai/desktop/session/a14eaccd7dce45b699560a36573e4c60?variant=devin
Requested by: @jadoonf


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Runtime evidence (Garnet)

No runtime evidence is bound to head 090a147 yet. The sticky Garnet Runtime Review comment either has not been posted for this head or describes an earlier commit. Missing evidence means no record, not a clean run.

Undeterminable means runtime behavior is unknown, never clean. An undeclared
capture only rules out a no-change claim; recorded changes stand. Matches the
amended shared paragraph in garnet-runtime-review-mcp docs/reviewers.md.
@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: garnet-labs/pnpm/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 0eacde8d-6dc7-4182-acf1-5e48d69151f2

📥 Commits

Reviewing files that changed from the base of the PR and between f7772a9 and 090a147.


📒 Files selected for processing (3)
  • .coderabbit.yaml
  • .pr_agent.toml
  • pr_compliance_checklist.yaml

 _____________________________________________________________
< Please stop using global state like it's a communal fridge. >
 -------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jadoonf
jadoonf marked this pull request as ready for review October 9, 2026 18:00
@jadoonf
jadoonf merged commit 6c8d4c9 into main Oct 9, 2026
26 checks passed
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Report recorded Garnet changes without complete capture

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Preserve recorded runtime changes as review evidence even when capture is not declared complete.
• Treat undeterminable records as unknown; reserve no-change claims for declared-complete captures.
• Align CodeRabbit and Qodo guidance; the Qodo checklist requires portal re-import.
Diagram

graph TD
  CFG["Reviewer guidance"] --> REC["Head-bound record"] --> DET{"Undeterminable?"}
  DET -- Yes --> UNK["Unknown behavior"]
  DET -- No --> CHG{"Recorded changes?"}
  CHG -- Yes --> REPORT["Correlate changes"]
  CHG -- No --> CAP{"Capture complete?"}
  CAP -- Yes --> CLEAN["No-change claim"]
  CAP -- No --> UNK
Loading
High-Level Assessment

Keeping the rule explicit in each reviewer's existing configuration is appropriate for this focused correction. A shared reference would reduce duplication but would not reliably replace tool-specific instructions or the Qodo portal re-import.

Files changed (3) +20 / -16

Other (3) +20 / -16
.coderabbit.yamlClarify CodeRabbit's Garnet evidence rule +6/-4

Clarify CodeRabbit's Garnet evidence rule

• Directs CodeRabbit to correlate recorded changes even without declared-complete capture. Undeterminable records remain unknown, and incomplete capture cannot justify saying nothing changed.

.coderabbit.yaml

.pr_agent.tomlAlign Qodo review guidance with recorded-change handling +6/-5

Align Qodo review guidance with recorded-change handling

• Replaces the blanket rejection of incomplete-capture evidence with instructions to report recorded changes. No-change claims still require declared-complete capture.

.pr_agent.toml

pr_compliance_checklist.yamlRevise Garnet compliance success and failure criteria +8/-7

Revise Garnet compliance success and failure criteria

• Allows head-bound records with recorded changes to satisfy the reporting criterion without declared-complete capture. Reserves the unknown-runtime failure for still-recording or undeterminable records and requires complete capture for a no-change claim; the revised checklist must be re-imported into Qodo.

pr_compliance_checklist.yaml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Code Suggestions ✨

Warning

/improve is deprecated. Use /agentic_review instead (removal date not yet scheduled).

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant