Skip to content

fix(pnpm): resolve the native binary download against the configured registry - #124

Open
jadoonf wants to merge 1 commit into
garnet/v140-basefrom
garnet/v140-change
Open

jadoonf wants to merge 1 commit into
garnet/v140-basefrom
garnet/v140-change

Conversation

@jadoonf

@jadoonf jadoonf commented Oct 29, 2026 •

Copy link
Copy Markdown

Fork-only canary: the routing change, compared against the recorded baseline.


Generated by Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Copilot AI balanced review requested due to automatic review settings October 29, 2026 20:08
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 4
  • ^garnet/bootstrap-routing-base$
  • ^garnet/routing-base$
  • ^garnet3/routing-base$
  • ^garnet/proxy-base$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Use configured registries for pnpm's native binary download

🐞 Bug fix ✨ Enhancement 🧪 Tests ⚙️ Configuration changes 🕐 40+ Minutes

Grey Divider

AI Description

• Route first-run native binary downloads through configured registries and credentials while
 preserving signature safeguards.
• Add tests for registry precedence, authentication, workspace configuration, and unchecked
 downloads.
• Add a fork-only Runtime Review CLI and workflow to publish head-bound CI evidence.
Diagram

graph TD
  A["pnpm entry"] --> B["Registry policy"] --> C["get-pnpm"] --> D["Native registry"]
  E["Evidence workflow"] --> F["Review CLI"] --> H["GitHub check"]
  G["GitHub/Garnet evidence"] --> F
  E -. "tracks entry" .-> A
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Reuse an npm configuration loader
  • ➕ Could provide broader .npmrc parsing compatibility and established precedence rules.
  • ➖ Adds bootstrap dependencies or bundling to an entry point that must work without installed dependencies.

Recommendation: Keep the self-contained bootstrap implementation for Corepack's dependency-free first run. Review its deliberately limited .npmrc parsing and credential precedence against the required npm behavior; a shared loader is preferable only if compatibility needs expand enough to justify bundling it.

Files changed (19) +2860 / -21

Enhancement (12) +2225 / -0
garnet-runtime-review.jsAdd Runtime Review CLI entry point +253/-0

Add Runtime Review CLI entry point

• Adds MCP stdio and HTTP serving, pull-request checks, profile lookup, waiting, output modes, annotations, and GitHub check publication. Restricts credential-enabled HTTP serving to loopback requests.

.garnet/runtime-review/bin/garnet-runtime-review.js

check-line.jsSummarize head-bound evidence in a check line +257/-0

Summarize head-bound evidence in a check line

• Builds bounded, sanitized check lines for new behavior, no change, or incomplete capture. Reports relevant changed-file classes without claiming they caused observed connections.

.garnet/runtime-review/src/check-line.js

consumer-verdict.jsEvaluate records with fail-closed verdicts +239/-0

Evaluate records with fail-closed verdicts

• Rejects stale, inconsistent, or incomplete evidence before making a no-change claim. Distinguishes first snapshots and observed changes from complete, unchanged comparisons.

.garnet/runtime-review/src/consumer-verdict.js

execution-profile.jsRead public execution profiles +189/-0

Read public execution profiles

• Fetches and summarizes a public job profile's connections and process ancestry. Adds GitHub run context and optional binding checks against a pull request's current head.

.garnet/runtime-review/src/execution-profile.js

garnet-profile.jsSupport opt-in local Garnet profiles +141/-0

Support opt-in local Garnet profiles

• Reads private-project profiles through garnetctl without a shell and summarizes network peers and assertions. Redacts token-like data from CLI errors.

.garnet/runtime-review/src/garnet-profile.js

http.jsExpose stateless MCP over HTTP +73/-0

Expose stateless MCP over HTTP

• Adds a JSON-response HTTP transport for MCP requests with method handling and a bounded request body.

.garnet/runtime-review/src/http.js

mcp.jsDispatch Runtime Review MCP tools +95/-0

Dispatch Runtime Review MCP tools

• Implements JSON-RPC initialization, discovery, and tool calls, including batch handling and structured tool results.

.garnet/runtime-review/src/mcp.js

parse-runtime-review.jsParse and reconcile review markers +282/-0

Parse and reconcile review markers

• Normalizes the machine-readable Runtime Review summary and compares its counts with rendered comment totals to detect drift.

.garnet/runtime-review/src/parse-runtime-review.js

runtime-review-diff.jsExtract job and destination changes +158/-0

Extract job and destination changes

• Parses rendered job trees into destinations, execution chains, and steps. Separates workload changes from recognized runner and platform noise.

.garnet/runtime-review/src/runtime-review-diff.js

runtime-review.jsAssemble head-bound Runtime Review results +434/-0

Assemble head-bound Runtime Review results

• Reads public pull-request records and selected profiles, applies the consumer verdict, and returns review-relevant changes with a check line. Treats unreadable job folds or missing head-bound evidence as undeterminable.

.garnet/runtime-review/src/runtime-review.js

stdio.jsServe MCP messages over stdio +32/-0

Serve MCP messages over stdio

• Adds newline-delimited JSON-RPC transport and waits for pending tool calls when input closes.

.garnet/runtime-review/src/stdio.js

tools.jsRegister public and opt-in review tools +72/-0

Register public and opt-in review tools

• Wires Runtime Review and public profile tools into the CLI transports. Exposes the garnetctl-backed profile tool only when explicitly enabled.

.garnet/runtime-review/src/tools.js

Bug fix (1) +180 / -11
pnpm.mjsResolve first-run downloads against configured registries +180/-11

Resolve first-run downloads against configured registries

• Selects Corepack or npm-configured registries and matching credentials before invoking get-pnpm. Reads project .npmrc only for signature-checked downloads and limits .npmrc credentials to HTTPS or loopback registries.

pnpm/npm/pnpm/bin/pnpm.mjs

Tests (2) +136 / -10
corepack-entry.test.mjsTest bootstrap registry routing and safeguards +132/-9

Test bootstrap registry routing and safeguards

• Adds first-run tests for user and workspace .npmrc files, scoped registry and credential precedence, and rejection of project-selected registries for unchecked downloads. Isolates inherited npm configuration in the test child process.

pnpm/npm/pnpm/test/corepack-entry.test.mjs

registry-fixture.mjsCapture fixture registry requests +4/-1

Capture fixture registry requests

• Records request paths and authorization headers so bootstrap tests can assert where metadata and archives were fetched and which credentials were sent.

pnpm/npm/pnpm/test/registry-fixture.mjs

Documentation (2) +7 / -0
bootstrap-download-reads-npmrc.mdRecord the bootstrap registry fix +5/-0

Record the bootstrap registry fix

• Adds a pacquet patch changeset describing configured registry and credential support, Corepack precedence, and the signature-related project .npmrc restriction.

.changeset/bootstrap-download-reads-npmrc.md

README.mdIdentify the fork-only review CLI +2/-0

Identify the fork-only review CLI

• Documents the vendored, dependency-free Runtime Review CLI snapshot used by the evidence workflow.

.garnet/runtime-review/README.md

Other (2) +312 / -0
github-check.jsPublish runtime evidence to GitHub checks +262/-0

Publish runtime evidence to GitHub checks

• Fetches changed files, selects annotation locations, and builds workflow commands and check-run payloads. Includes the check line, destination changes, profile links, and policy-based conclusions.

.garnet/runtime-review/src/github-check.js

garnet3-evidence-check.ymlPublish fork-only head-bound evidence +50/-0

Publish fork-only head-bound evidence

• Adds a pull-request workflow for bootstrap and review-tool changes. It waits for a record bound to the head, publishes annotations and a GitHub check, and fails on workload changes.

.github/workflows/garnet3-evidence-check.yml

@garnet-runtime-review

garnet-runtime-review Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Runtime behavior changed

1 job changed
1 job recorded at the kernel · ubuntu-24.04 (Linux x86_64)

At dbdc1c9, compared with the PR base cbe4d1e
Commit Change to this head
head dbdc1c9
garnet/v140-change · run 40948872262
previous push 1004c0d
run 40946418167
nothing new
PR base cbe4d1e
garnet/v140-base · run 40947547734
the job folds above
Garnet Bootstrap Routing / bootstrap-routing (ubuntu, node 22) · +1 −2
 ↳ python3.12 no longer reaches 169.254.169[.]254
 ↳ bash › node now reaches cdn.npmmirror[.]com
 ↳ bash › node no longer reaches registry.npmjs[.]org
  systemd
  └─ python3.12
-    └─ python3.12
-       └─ ○ 169.254.169[.]254 (Cloud IMDS)

  Runner.Worker › … (1) › bash
  └─ node
+    ├─ ○ cdn.npmmirror[.]com
-    └─ ○ registry.npmjs[.]org
Runner activity outside your workflow · +3 · not counted
  systemd
    ├─ … (1)
    │  └─ python3.12
    │     └─ ○ 168.63.129[.]16
    ├─ systemd-resolved
    │  └─ ○ 168.63.129[.]16
+   └─ … (2)
+       └─ provjobd1507264542
+        └─ ○ hosted-compute-watchdog-prod-iad-02[.]githubapp (github infra)

Job log · Full record in Garnet ↗


How to read this
Runner.Worker     ← process on a path
└─ curl           ← process that acted
   └─ ○ example[.]com ← observed action

Read down: what ran, then what it reached. + only in this commit · − only in the compared run. Capture is best-effort. · Docs ↗

Runtime behavior, recorded by Garnet. Add it to your CI ↗

@qodo-code-review

qodo-code-review Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (10) 📘 Rule violations (3) 📜 Skill insights (2)

Grey Divider


Action required

1. A project registry receives user tokens 📜 Skill insight ⛨ Security
Description
registryAccess merges the repository .npmrc into the user settings and then passes the selected
registry to npmrcHeaders, which searches those merged settings for authorization. A repository
can therefore set a literal registry such as npmjs and cause a user's matching registry token from
their home .npmrc to be sent during the native binary download.
Code

pnpm/npm/pnpm/bin/pnpm.mjs[R113-121]

+  const npmrc = readUserNpmrc()
+  if (readProjectNpmrc) {
+    Object.assign(npmrc, readNpmrc(path.join(projectDir(), '.npmrc'), projectEntry))
+  }
+  const registry = npmrc['@pnpm:registry'] || settingFromEnv('registry') || npmrc.registry
+  if (!registry) {
+    return { registry: DEFAULT_REGISTRY, headers: corepackHeaders() }
+  }
+  return { registry, headers: npmrcHeaders(npmrc, registry) }
Relevance

●●● Strong

Project-selected registries can receive matching user credentials from merged npm configuration.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The changed code first loads the user .npmrc, merges project settings into the same object,
selects a registry from the merged values, and then resolves authorization from that merged object.
The credential resolver includes registry-wide and scoped entries, so a project-selected registry
can receive a user's matching token.

pnpm/npm/pnpm/bin/pnpm.mjs[108-121]
pnpm/npm/pnpm/bin/pnpm.mjs[228-250]
Skill: review-code

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

Issue description
A repository-controlled `.npmrc` can select a registry, after which the merged configuration lets that registry receive matching user-level credentials. This violates the trust boundary for repository-selected registries.

Fix Focus Areas
- pnpm/npm/pnpm/bin/pnpm.mjs[113-121]
- pnpm/npm/pnpm/bin/pnpm.mjs[228-250]

Recommended Fix
Keep repository-selected registry values separate from user authentication settings. Do not look up or send user-level credentials when the effective registry comes from the project `.npmrc`; require an explicit trusted user-level scope or another clear trust boundary before attaching authorization headers, and add a regression test covering a project-selected registry with a matching user token.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


2. A mismatched record can pass the check 🐞 Bug ≡ Correctness
Description
getRuntimeReview extracts marker_commit but determines headBound solely from the summary’s
commit field. If the bot comment’s garnet:commit marker is missing or names another SHA while its
summary names the current head, the CLI can classify it as no-change and publish a successful
check despite having no marker-bound record.
Code

.garnet/runtime-review/src/runtime-review.js[R99-101]

+  const markerCommit = /<!--\s*garnet:commit\s+([0-9a-f]{40})\s*-->/.exec(body ?? "")?.[1] ?? null;
+  const headBound = !pending && verdict.record?.comparison?.headSha === headSha;
+  let bound = verdict.verdict !== "undeterminable";
Relevance

●●● Strong

Head binding must verify the marker and summary consistently; accepted history favors fail-closed
head checks.

PR-#28

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The parser obtains the comparison SHA from summary.commit; the consumer checks that SHA, while
headBound does not check the separately extracted HTML marker. A bound no-change assessment can
produce a successful check run. The existing gate, by contrast, requires the HTML marker to match
the head.

.garnet/runtime-review/src/parse-runtime-review.js[61-80]
.garnet/runtime-review/src/consumer-verdict.js[70-77]
.garnet/runtime-review/src/runtime-review.js[94-101]
.garnet/runtime-review/src/github-check.js[178-188]
.github/scripts/garnet-evidence-gate.mjs[68-80]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new evidence consumer can report a successful head-bound check without a matching HTML commit marker.
## Fix Focus Areas
- .garnet/runtime-review/src/runtime-review.js[94-101]
- .garnet/runtime-review/src/consumer-verdict.js[61-80]
## Recommended Fix
Require the bot comment's `garnet:commit` marker and the parsed summary commit to equal the current PR head before returning a bound verdict. Treat a missing or mismatched marker as undeterminable.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


3. Pull requests can forge a passing check 🐞 Bug ⛨ Security
Description
The evidence workflow checks out the pull request head and runs its .garnet/runtime-review code
with a token granted checks: write. A contributor who can open a same-repository pull request can
change that code to publish a successful garnet/evidence check without evaluating the runtime
record.
Code

.github/workflows/garnet3-evidence-check.yml[R36-40]

+      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          persist-credentials: false
+          sparse-checkout: .garnet/runtime-review
Relevance

●●● Strong

Executing contributor-controlled workflow code with checks:write permits forging the passing
evidence check.

PR-#43

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The job grants check-writing permission, checks out the PR head, and passes its token to the
checked-out entry point. That entry point imports local modules and can use the token to create a
check run.

.github/workflows/garnet3-evidence-check.yml[31-50]
.garnet/runtime-review/bin/garnet-runtime-review.js[4-10]
.garnet/runtime-review/src/github-check.js[253-259]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The workflow executes pull-request-controlled publisher code while supplying a check-writing token.
## Fix Focus Areas
- .github/workflows/garnet3-evidence-check.yml[31-50]
## Recommended Fix
Run the publisher from a trusted base-branch revision, not the pull request checkout. Keep the write token available only to that trusted publication step; treat pull-request content solely as data.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


View high (1)
4. Invalid pull request numbers reach GitHub 📜 Skill insight ⛨ Security
Description
parseTarget converts the supplied pull-request text with Number() and accepts it when it is a
positive safe integer, rather than requiring the decimal-digit format. Inputs such as 1e2 or +1
therefore reach GitHub API URL construction and lookup despite the command contract requiring
^[0-9]+$.
Code

.garnet/runtime-review/src/runtime-review.js[R43-46]

+    const path = repo.replace(/^https:\/\/github\.com\//, "").replace(/\.git$/, "").replace(/\/+$/, "");
+    [owner, name] = path.split("/");
+    if (path.split("/").length !== 2) owner = undefined;
+  }
Relevance

●●● Strong

Number() accepts non-decimal forms despite the documented decimal-only pull-request contract.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The target parser converts the requested PR with Number() and only checks numeric safety and
positivity, allowing non-decimal representations that do not satisfy the required decimal-digit
format. The resulting number is then used by the GitHub API lookup.

.garnet/runtime-review/src/runtime-review.js[43-46]
Skill: pull-requests

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

Issue description
The pull-request argument is converted with `Number()` before being checked, so syntactically invalid values such as `1e2` and `+1` are accepted and used in GitHub API requests.

Fix Focus Areas
- .garnet/runtime-review/src/runtime-review.js[43-46]
- .garnet/runtime-review/bin/garnet-runtime-review.js[170-174]

Recommended Fix
Validate the raw pull-request string against `^[0-9]+$` before calling `Number()` or constructing any API path. Reject invalid values with `InputError`, then convert only the validated decimal string to a safe integer.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗



Remediation recommended

5. Unreadable npmrc settings are ignored 📘 Rule violation ≡ Correctness ⭐ New
Description
readNpmrc catches every filesystem error and returns an empty settings object after logging only
errors other than missing-file and directory cases. Permission failures, I/O errors, and other
unexpected failures therefore continue as if the configuration were absent, affecting registry
selection and credentials.
Code

pnpm/npm/pnpm/bin/pnpm.mjs[R189-192]

+    if (err.code !== 'ENOENT' && err.code !== 'EISDIR') {
+      console.error(`Could not read ${file}, so its settings are not used: ${err.message}`)
+    }
+    return settings
Relevance

●●● Strong

Unexpected filesystem errors should not be silently converted into missing configuration.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The changed catch block logs non-ENOENT/non-EISDIR errors but then returns an empty settings
object instead of propagating them, so unexpected read failures are silently converted into missing
configuration.

Rule 2757176: Catch only specific, expected error types or codes in TypeScript
pnpm/npm/pnpm/bin/pnpm.mjs[186-192]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

Issue description
`readNpmrc` treats unexpected filesystem failures as if the `.npmrc` file were absent, which can silently change registry and credential behavior.

Fix Focus Areas
- pnpm/npm/pnpm/bin/pnpm.mjs[186-192]

Recommended Fix
Handle only the expected `ENOENT` and `EISDIR` cases as missing configuration. Rethrow or otherwise propagate all other filesystem errors after preserving useful path context.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


6. Registry tests bypass the shared test harness 📘 Rule violation ▣ Testability ⭐ New
Description
The new workspace .npmrc test starts a separate registry with the local startRegistry fixture
instead of using the repository's pnpm-testing-utils startup API. This leaves the added
mocked-registry coverage outside the standard setup and lifecycle managed by the shared test
utilities.
Code

pnpm/npm/pnpm/test/corepack-entry.test.mjs[R184-187]

+  it('downloads from the registry the workspace .npmrc names, without expanding its credentials', async () => {
+    const fixture = await createFixture()
+    const userRegistry = await startRegistry({ payload: FAKE_BINARY })
+    after(userRegistry.close)
Relevance

●●● Strong

The added test should follow the repository’s explicitly required shared mocked-registry setup.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The changed test directly calls the local startRegistry helper to create the mocked package
registry, rather than using the required shared pnpm-testing-utils API.

Rule 2757281: Start mocked registry programmatically via pnpm-testing-utils in tests
pnpm/npm/pnpm/test/corepack-entry.test.mjs[184-192]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new mocked-registry test starts a registry directly with the local `startRegistry` fixture, rather than starting it through the required `pnpm-testing-utils` API.

## Fix Focus Areas
- pnpm/npm/pnpm/test/corepack-entry.test.mjs[184-187]
- pnpm/npm/pnpm/test/registry-fixture.mjs[45-85]

## Recommended Fix
Replace the direct `startRegistry` call with the supported `pnpm-testing-utils` mocked-registry startup and teardown flow, while preserving the test's ability to serve the fake binary and assert that the user registry receives no project credential expansion.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


7. A crafted job name alters reviewer output 🐞 Bug ⛨ Security ⭐ New
Description
renderProfileBrief inserts profile-provided workflow, job, and ref values directly into the
Markdown brief without quoting or escaping them. When a reviewer opens a public Execution Profile
for a contributor-controlled workflow, a name containing Markdown structure can add reviewer-facing
text outside the intended fields.
Code

.garnet/runtime-review/src/execution-profile.js[R169-171]

+    `## Garnet Execution Profile — ${run.repository ?? "?"} · ${run.workflow ?? "?"} / ${run.job ?? "?"}`,
+    "",
+    `- Run ${run.run_id ?? "?"} · commit ${String(run.commit_sha ?? "?").slice(0, 7)} · ref ${run.ref ?? "?"}`,
Relevance

●●● Strong

Contributor-controlled Markdown is rendered unquoted; existing reviewer-facing conventions support
escaping observed names.

PR-#63

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The tool copies the fetched public profile's run object into its result, then interpolates its
fields into the brief. MCP returns that brief as text to the caller; the neighboring runtime-review
renderer already uses a quoting helper for observed names.

.garnet/runtime-review/src/execution-profile.js[63-71]
.garnet/runtime-review/src/execution-profile.js[88-99]
.garnet/runtime-review/src/execution-profile.js[165-175]
.garnet/runtime-review/src/mcp.js[58-66]
.garnet/runtime-review/src/runtime-review.js[298-310]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Profile and run metadata can alter the Markdown brief shown to a reviewer because it is interpolated without quoting.

## Fix Focus Areas
- .garnet/runtime-review/src/execution-profile.js[165-188]
- .garnet/runtime-review/src/garnet-profile.js[133-140]

## Recommended Fix
Render profile-provided names and refs as inert data, using the existing code-fencing helper or equivalent escaping. Apply the same treatment to the local profile brief.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


View medium (6)
8. Empty snapshots lose recorded status 🐞 Bug ≡ Correctness ⭐ New
Description
unreadableJobsReason treats every first snapshot with zero parsed job folds as unreadable, even
when its marker reports zero jobs. A head-bound, internally consistent empty snapshot is
consequently rewritten from recorded to undeterminable instead of receiving the first-snapshot
assessment.
Code

.garnet/runtime-review/src/runtime-review.js[R352-354]

+  if (verdict.verdict === "recorded" && jobs.length === 0) {
+    return "the snapshot renders no readable job folds, so the recorded jobs and destinations cannot be shown";
+  }
Relevance

●●● Strong

Zero is a valid recorded count; empty first snapshots should preserve the recorded assessment.

PR-#115

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The parser accepts zero as a valid count and reconciles it with the rendered headline. The consumer
classifies a first snapshot as recorded, but the subsequent unreadable-fold check rejects an empty
jobs array and changes that verdict.

.garnet/runtime-review/src/parse-runtime-review.js[101-108]
.garnet/runtime-review/src/parse-runtime-review.js[145-151]
.garnet/runtime-review/src/consumer-verdict.js[89-101]
.garnet/runtime-review/src/runtime-review.js[103-112]
.garnet/runtime-review/src/runtime-review.js[348-358]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A valid first snapshot declaring zero jobs is rejected because it has no job folds.

## Fix Focus Areas
- .garnet/runtime-review/src/runtime-review.js[348-358]

## Recommended Fix
Require a readable fold only when the snapshot declares at least one job. Add a zero-job snapshot case while retaining the rejection of missing folds for positive job counts.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


9. Unsigned downloads can still follow a repo's registry 🐞 Bug ⛨ Security ⭐ New
Description
When COREPACK_INTEGRITY_KEYS turns the signature check off, registryAccess skips reading the
project .npmrc, but it still takes the registry from settingFromEnv('registry'), which reads
npm_config_registry. If pnpm runs inside an npm run or npm test script in an untrusted
repository, npm turns that repository's .npmrc registry= into npm_config_registry, so the
repository still picks where the unverified binary comes from, and that binary is cached next to the
wrapper (the GHSA-j2hc-m6cf-6jm8 path this change says it closes).
Code

pnpm/npm/pnpm/bin/pnpm.mjs[R113-117]

+  const npmrc = readUserNpmrc()
+  if (readProjectNpmrc) {
+    Object.assign(npmrc, readNpmrc(path.join(projectDir(), '.npmrc'), projectEntry))
+  }
+  const registry = npmrc['@pnpm:registry'] || settingFromEnv('registry') || npmrc.registry
Relevance

●●● Strong

Environment-derived registry configuration can bypass the intended unchecked-download protection.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The readProjectNpmrc gate only covers the file read. The env lookup on line 117 runs whether or
not the signature is checked. npm puts project config into the environment of its lifecycle scripts
as npm_config_*, and the npm/cli issue shows registry coming from the environment when a script
runs under npm test. So the env value is not necessarily something the user set.

pnpm/npm/pnpm/bin/pnpm.mjs[108-122]
pnpm/npm/pnpm/bin/pnpm.mjs[136-141]
🌐 The registry property is inherited from the environment (npmConfig\(&#x27;registry&#x27;\) === &#x27;env&#x27;) when the code runs through npm test.

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
When the signature check is off, the project `.npmrc` is skipped, but `npm_config_registry`/`pnpm_config_registry` is still used. Package managers fill those variables from the project `.npmrc` for scripts, so a repository can still choose where an unsigned binary is downloaded from.

## Fix Focus Areas
- pnpm/npm/pnpm/bin/pnpm.mjs[108-122]
- pnpm/npm/pnpm/bin/pnpm.mjs[136-141]

## Recommended Fix
Pass the same trust flag to the env lookup: when `readProjectNpmrc` is false, skip `settingFromEnv('registry')` and use only `COREPACK_NPM_REGISTRY`, the user `.npmrc`, or the default registry. Alternatively, ignore the env registry when `npm_lifecycle_event` is set. Add a test that sets `npm_config_registry` together with `COREPACK_INTEGRITY_KEYS=0`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


10. Changed workloads get notice annotations 🐞 Bug ≡ Correctness
Description
buildAnnotations hard-codes notice for every file-anchored annotation instead of using
annotationLevel(result, failOn). When the workflow fails on workload-change and finds a
classifiable changed file, its published file annotation is only a notice, and --github-check
suppresses a separate workflow annotation.
Code

.garnet/runtime-review/src/github-check.js[87]

+    anchors.push({ path, line, level: "notice", title, message });
Relevance

●●● Strong

Anchored annotations ignore fail-on severity, suppressing failure-level workload annotations in
GitHub checks.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The level helper returns failure when the assessment matches failOn, but the anchored branch
uses notice. The workflow invokes the CLI with `--fail-on workload-change --annotate
--github-check`; in that mode, workflow annotations retain only file-less entries.

.garnet/runtime-review/src/github-check.js[41-44]
.garnet/runtime-review/src/github-check.js[75-99]
.github/workflows/garnet3-evidence-check.yml[44-50]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
File-anchored annotations do not reflect the assessment's configured failure level.
## Fix Focus Areas
- .garnet/runtime-review/src/github-check.js[75-93]
## Recommended Fix
Use `annotationLevel(result, failOn)` for anchored annotations as well as the file-less fallback, and test the `workload-change` path with an anchorable changed file.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


11. Large batches can exhaust the server 🐞 Bug ➹ Performance
Description
handleMcpMessage starts every JSON-RPC batch member concurrently with Promise.all, without
limiting batch length or active calls. A caller of the HTTP endpoint can fit many tool calls within
its 64 KiB request limit and trigger simultaneous network lookups, or simultaneous subprocesses when
the local profile tool is enabled.
Code

.garnet/runtime-review/src/mcp.js[R22-24]

+  if (Array.isArray(message)) {
+    const responses = (await Promise.all(message.map((item) => handleOne(item, tools)))).filter((item) => item !== null);
+    return responses.length === 0 ? null : responses;
Relevance

●●● Strong

Unbounded batch concurrency can amplify network and subprocess work beyond intended request-size
limits.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The HTTP handler dispatches the parsed body directly to the batch handler, which concurrently maps
every element to handleOne. The exposed tools perform outbound requests, and the opt-in profile
tool launches garnetctl.

.garnet/runtime-review/src/http.js[29-36]
.garnet/runtime-review/src/mcp.js[22-24]
.garnet/runtime-review/src/tools.js[43-59]
.garnet/runtime-review/src/garnet-profile.js[33-43]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
One HTTP batch can launch an unbounded number of network-backed or subprocess-backed tool calls at once.
## Fix Focus Areas
- .garnet/runtime-review/src/mcp.js[22-26]
- .garnet/runtime-review/src/http.js[29-36]
## Recommended Fix
Reject batches above a documented maximum and limit concurrently executing tool calls. Apply the same execution bound to requests arriving at the HTTP endpoint.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


12. The native-download fix gets the wrong release bump 📘 Rule violation § Compliance
Description
The new changeset declares a pacquet patch instead of a pnpm release entry for the TypeScript
native-download change. Because the changed implementation and tests are under the TypeScript pnpm
package, release automation will not version the package that users receive.
Code

.changeset/bootstrap-download-reads-npmrc.md[R1-3]

+---
+"pacquet": patch
+---
Relevance

●●● Strong

The changeset targets the wrong package; release automation would omit the modified pnpm package.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The changeset front matter names only pacquet, while the changed implementation is
pnpm/npm/pnpm/bin/pnpm.mjs and the associated tests are in pnpm/npm/pnpm/test. This is a
TypeScript CLI changeset without the required pnpm package entry.

Rule 2757156: Changesets for TypeScript CLI must include a pnpm package bump
.changeset/bootstrap-download-reads-npmrc.md[1-3]
pnpm/npm/pnpm/bin/pnpm.mjs[82-88]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

Issue description
The changeset targets `pacquet`, but this PR changes the TypeScript `pnpm` package's native binary download behavior.

Fix Focus Areas
- .changeset/bootstrap-download-reads-npmrc.md[1-3]

Recommended Fix
Replace the `pacquet` front-matter entry with the repository's exact published package name for the TypeScript CLI, `pnpm`, and keep the `patch` bump for this bug fix.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


13. First run fails when the configured mirror drops npm signatures 🐞 Bug ☼ Reliability
Description
registryAccess now sends the bootstrap download to whatever registry the user or project .npmrc
(or npm_config_registry) names. signaturePolicy still checks that download against npm's own
keys whenever COREPACK_INTEGRITY_KEYS is unset. Some internal mirrors republish packages without
npm's dist.signatures. For a user behind one of those who installed pnpm without Corepack, the
first run used to download from registry.npmjs.org and work. It now fails with a signature error,
and nothing in the message points to COREPACK_INTEGRITY_KEYS=0.
Code

pnpm/npm/pnpm/bin/pnpm.mjs[R117-121]

+  const registry = npmrc['@pnpm:registry'] || settingFromEnv('registry') || npmrc.registry
+  if (!registry) {
+    return { registry: DEFAULT_REGISTRY, headers: corepackHeaders() }
+  }
+  return { registry, headers: npmrcHeaders(npmrc, registry) }
Relevance

●● Moderate

Configured mirrors without npm signatures can break first-run verification, but registry signing is
an operational assumption.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
Before this PR, registry was COREPACK_NPM_REGISTRY || DEFAULT_REGISTRY, so a mirror configured
only in .npmrc was never contacted. Now any registry/@pnpm:registry setting is used.
signaturePolicy returns {} (verify against npm keys) when COREPACK_INTEGRITY_KEYS is unset.
Its own comment says it assumes a re-publishing registry user already set that variable 'for
Corepack to have installed this wrapper', which does not hold for npm, pnpm or other non-Corepack
installs. The registry fixture shows the check needs a dist.signatures entry signed by a trusted
key.

pnpm/npm/pnpm/bin/pnpm.mjs[108-122]
pnpm/npm/pnpm/bin/pnpm.mjs[279-310]
pnpm/npm/pnpm/test/registry-fixture.mjs[1-7]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The bootstrap now downloads from the `.npmrc`-configured registry, but it still requires npm's signature when `COREPACK_INTEGRITY_KEYS` is unset. Mirrors that drop `dist.signatures` used to work, because the download went to registry.npmjs.org. They now fail on first run.

## Fix Focus Areas
- pnpm/npm/pnpm/bin/pnpm.mjs[82-93]
- pnpm/npm/pnpm/bin/pnpm.mjs[108-122]

## Recommended Fix
When the download fails signature verification and the registry came from `.npmrc` or the environment (not `COREPACK_NPM_REGISTRY`), extend the `fail` message to name the registry that was used. Also tell the user that setting `COREPACK_INTEGRITY_KEYS=0`, or a key set for that registry, is required. Add a changeset note and a test for an unsigned mirror configured in the user `.npmrc`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗



Informational

14. Published wrapper ships a fork-only comment 🐞 Bug ⚙ Maintainability ⭐ New
Description
The last line of the shipped pnpm.mjs adds `// Recorded by the fork-only Garnet Bootstrap Routing
workflow. to the npm pnpm` package entry point. That workflow is not part of this repository, so
anyone who later reads the published wrapper finds a reference to tooling that does not exist.
Code

pnpm/npm/pnpm/bin/pnpm.mjs[R315-316]

+
+// Recorded by the fork-only Garnet Bootstrap Routing workflow.
Relevance

●● Moderate

The comment is fork-specific, but the PR explicitly documents fork-only tooling and intent.

PR-#91

ⓘ Recommendations generated based on similar findings in past PRs

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A fork-only Garnet comment was added to the end of the published pnpm wrapper.

## Fix Focus Areas
- pnpm/npm/pnpm/bin/pnpm.mjs[315-316]

## Recommended Fix
Delete the trailing blank line and the `// Recorded by the fork-only Garnet Bootstrap Routing workflow.` comment.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


15. Running pnpm in an untrusted clone contacts a host the repo picks 🐞 Bug ⛨ Security
Description
With the signature check enabled (the default), registryAccess({ readProjectNpmrc: true }) merges
the project .npmrc over the user one. The project's @pnpm:registry also beats both the env var
and the user's registry. The first pnpm command in a freshly cloned repository therefore makes
HTTP requests to a host the repository author chose. That discloses the user's IP, platform/arch and
pnpm version, and lets the host stall or flood the download, although the binary bytes stay
signature-pinned.
Code

pnpm/npm/pnpm/bin/pnpm.mjs[R113-117]

+  const npmrc = readUserNpmrc()
+  if (readProjectNpmrc) {
+    Object.assign(npmrc, readNpmrc(path.join(projectDir(), '.npmrc'), projectEntry))
+  }
+  const registry = npmrc['@pnpm:registry'] || settingFromEnv('registry') || npmrc.registry
Relevance

●● Moderate

The behavior is intentional routing, but contacting repository-selected hosts creates meaningful
untrusted-clone risk.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
Object.assign(npmrc, readNpmrc(path.join(projectDir(), '.npmrc'), projectEntry)) runs whenever
verifySignature !== false, which includes the default unset case. Line 117 then takes
npmrc['@pnpm:registry'] first. Credentials are keyed by host, so user tokens do not leak. The new
test 'downloads from the registry the workspace .npmrc names' confirms that the repository chooses
the endpoint.

pnpm/npm/pnpm/bin/pnpm.mjs[82-88]
pnpm/npm/pnpm/bin/pnpm.mjs[108-122]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A project `.npmrc` can direct pnpm's first-run bootstrap request to any host, and its `@pnpm:registry` even beats `npm_config_registry`.

## Fix Focus Areas
- pnpm/npm/pnpm/bin/pnpm.mjs[113-117]

## Recommended Fix
Rank `settingFromEnv('registry')` above a project-sourced `@pnpm:registry`, so an explicit environment choice is never overridden by the repository. Also print the registry host in the 'Downloading the pnpm … binary' line so the user can see where the request goes.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


Grey Divider

Context sources
✅ Compliance rules (platform): 91 rules
✅ Web pages:
  +2 more
Review mode: Auto: 🧠 Deep: Large security-sensitive PR spans many independent runtime and registry code paths.

Grey Divider

⚠️ Warning | Comment size exceeded, non finding content trimmed Learn more

Grey Divider

Qodo Logo

Comment on lines +43 to +46
const path = repo.replace(/^https:\/\/github\.com\//, "").replace(/\.git$/, "").replace(/\/+$/, "");
[owner, name] = path.split("/");
if (path.split("/").length !== 2) owner = undefined;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Invalid pull request numbers reach github 📜 Skill insight ⛨ Security

parseTarget converts the supplied pull-request text with Number() and accepts it when it is a
positive safe integer, rather than requiring the decimal-digit format. Inputs such as 1e2 or +1
therefore reach GitHub API URL construction and lookup despite the command contract requiring
^[0-9]+$.
Agent Prompt
Issue description
The pull-request argument is converted with `Number()` before being checked, so syntactically invalid values such as `1e2` and `+1` are accepted and used in GitHub API requests.

Fix Focus Areas
- .garnet/runtime-review/src/runtime-review.js[43-46]
- .garnet/runtime-review/bin/garnet-runtime-review.js[170-174]

Recommended Fix
Validate the raw pull-request string against `^[0-9]+$` before calling `Number()` or constructing any API path. Reject invalid values with `InputError`, then convert only the validated decimal string to a safe integer.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

Comment on lines +113 to +121
const npmrc = readUserNpmrc()
if (readProjectNpmrc) {
Object.assign(npmrc, readNpmrc(path.join(projectDir(), '.npmrc'), projectEntry))
}
const registry = npmrc['@pnpm:registry'] || settingFromEnv('registry') || npmrc.registry
if (!registry) {
return { registry: DEFAULT_REGISTRY, headers: corepackHeaders() }
}
return { registry, headers: npmrcHeaders(npmrc, registry) }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. A project registry receives user tokens 📜 Skill insight ⛨ Security

registryAccess merges the repository .npmrc into the user settings and then passes the selected
registry to npmrcHeaders, which searches those merged settings for authorization. A repository
can therefore set a literal registry such as npmjs and cause a user's matching registry token from
their home .npmrc to be sent during the native binary download.
Agent Prompt
Issue description
A repository-controlled `.npmrc` can select a registry, after which the merged configuration lets that registry receive matching user-level credentials. This violates the trust boundary for repository-selected registries.

Fix Focus Areas
- pnpm/npm/pnpm/bin/pnpm.mjs[113-121]
- pnpm/npm/pnpm/bin/pnpm.mjs[228-250]

Recommended Fix
Keep repository-selected registry values separate from user authentication settings. Do not look up or send user-level credentials when the effective registry comes from the project `.npmrc`; require an explicit trusted user-level scope or another clear trust boundary before attaching authorization headers, and add a regression test covering a project-selected registry with a matching user token.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

Comment on lines +36 to +40
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
ref: ${{ github.event.pull_request.head.sha }}
persist-credentials: false
sparse-checkout: .garnet/runtime-review

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

3. Pull requests can forge a passing check 🐞 Bug ⛨ Security

The evidence workflow checks out the pull request head and runs its .garnet/runtime-review code
with a token granted checks: write. A contributor who can open a same-repository pull request can
change that code to publish a successful garnet/evidence check without evaluating the runtime
record.
Agent Prompt
## Issue description
The workflow executes pull-request-controlled publisher code while supplying a check-writing token.
## Fix Focus Areas
- .github/workflows/garnet3-evidence-check.yml[31-50]
## Recommended Fix
Run the publisher from a trusted base-branch revision, not the pull request checkout. Keep the write token available only to that trusted publication step; treat pull-request content solely as data.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

Comment on lines +99 to +101
const markerCommit = /<!--\s*garnet:commit\s+([0-9a-f]{40})\s*-->/.exec(body ?? "")?.[1] ?? null;
const headBound = !pending && verdict.record?.comparison?.headSha === headSha;
let bound = verdict.verdict !== "undeterminable";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

4. A mismatched record can pass the check 🐞 Bug ≡ Correctness

getRuntimeReview extracts marker_commit but determines headBound solely from the summary’s
commit field. If the bot comment’s garnet:commit marker is missing or names another SHA while its
summary names the current head, the CLI can classify it as no-change and publish a successful
check despite having no marker-bound record.
Agent Prompt
## Issue description
The new evidence consumer can report a successful head-bound check without a matching HTML commit marker.
## Fix Focus Areas
- .garnet/runtime-review/src/runtime-review.js[94-101]
- .garnet/runtime-review/src/consumer-verdict.js[61-80]
## Recommended Fix
Require the bot comment's `garnet:commit` marker and the parsed summary commit to equal the current PR head before returning a bound verdict. Treat a missing or mismatched marker as undeterminable.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

@qodo-code-review

Copy link
Copy Markdown

PR Code Suggestions ✨

Warning

/improve is deprecated. Use /agentic_review instead (removal date not yet scheduled).

No code suggestions found for the PR.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved critical issues can redirect bootstrap downloads to public npm, misreport or fail to parse runtime-review evidence, and let an unauthenticated malformed request terminate the exposed server.

3 open issues
What changed in this PR

Updates pnpm’s native-binary bootstrap to use configured registries and credentials, and adds fork-only tooling to publish runtime evidence on pull requests.

Changes:

  • Reads registry settings and credentials from user/project .npmrc files and environment variables, preserving Corepack precedence.
  • Adds bootstrap tests for registry routing, authentication, and project-configuration restrictions when signature verification is disabled.
  • Adds a Garnet runtime-review CLI, MCP transports, parsers, and GitHub evidence-check workflow.
File Description
pnpm/​npm/​pnpm/​test/​registry-fixture.mjs Records request URLs and authorization headers.
pnpm/​npm/​pnpm/​test/​corepack-entry.test.mjs Tests configured registries and credential handling.
pnpm/​npm/​pnpm/​bin/​pnpm.mjs Resolves bootstrap registry access from configuration.
.github/​workflows/​garnet3-evidence-check.yml Publishes head-bound runtime evidence checks.
.garnet/​runtime-review/​src/​tools.js Defines runtime-review and profile tools.
.garnet/​runtime-review/​src/​stdio.js Provides the MCP stdio transport.
.garnet/​runtime-review/​src/​runtime-review.js Retrieves and summarizes runtime evidence.
.garnet/​runtime-review/​src/​runtime-review-diff.js Extracts jobs and destination changes.
.garnet/​runtime-review/​src/​parse-runtime-review.js Parses record metadata and reconciles counts.
.garnet/​runtime-review/​src/​mcp.js Handles MCP requests and tool calls.
.garnet/​runtime-review/​src/​http.js Provides the MCP HTTP transport.
.garnet/​runtime-review/​src/​github-check.js Builds annotations and publishes GitHub checks.
.garnet/​runtime-review/​src/​garnet-profile.js Reads opt-in local Garnet profiles.
.garnet/​runtime-review/​src/​execution-profile.js Retrieves public profiles and GitHub run context.
.garnet/​runtime-review/​src/​consumer-verdict.js Evaluates record validity and capture completeness.
.garnet/​runtime-review/​src/​check-line.js Formats concise evidence outcomes.
.garnet/​runtime-review/​README.md Documents the fork-only tooling snapshot.
.garnet/​runtime-review/​bin/​garnet-runtime-review.js Adds CLI commands and server entry points.
.changeset/​bootstrap-download-reads-npmrc.md Records the bootstrap routing fix for release.

Review effort: Balanced

}
const handler = createHttpHandler(createToolset({ githubToken, enableGarnetctl }));
createServer((request, response) => {
const path = new URL(request.url ?? "/", "http://localhost").pathname;
Comment on lines +112 to +115
if (facts.bound_to_head && facts.changes.length === 0) {
facts.outcome = "nothing new";
facts.reason = "workload unchanged; every changed destination is runner or platform noise";
} else facts.reason = `record for head ${head} is not bound to this head`;
Comment on lines +145 to +148
const headlineMatch = /\*\*Execution Profiles recorded for (\d+) jobs?\b/.exec(body);
checks.jobsHeadline = compareCheck(
counts.jobs,
headlineMatch === null ? null : Number(headlineMatch[1]),
@jadoonf
jadoonf changed the base branch from garnet/v140-control to garnet/v140-base October 29, 2026 20:25
@jadoonf
jadoonf force-pushed the garnet/v140-change branch from 1004c0d to dbdc1c9 Compare October 29, 2026 20:25
@qodo-code-review

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit dbdc1c9

@qodo-code-review

Copy link
Copy Markdown

PR Code Suggestions ✨

Warning

/improve is deprecated. Use /agentic_review instead (removal date not yet scheduled).

No code suggestions found for the PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants