Repository navigation
ci: route L4 step-name and evidence-mirror checks to optional - #63
Conversation
A missing quoted step name in the App comment and the PR-description evidence mirror report optional: step attribution is disclosed-unstable (F25) and the mirror is a reviewer-consumption experiment (F34). A missing destination or a second Garnet App comment on one head stays core.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe release gate now normalizes L4 App-comment evidence, downgrades selected missing evidence to optional misses, updates the L4 rationale, and builds L6 shape state with empty-array-safe note iteration. ChangesRelease gate validation
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Execution Profiles recorded for 2 jobs, triggered by
|
The comment defangs domains (`registry.npmjs[.]org`) and drops jibril's step-numbering prefix, so raw-body greps for `registry.npmjs.org` and `"2. Stop the action clock"` missed rendered-but-present evidence. Normalize the body (`[.]` -> `.`) and try the de-numbered step name.
|
/agentic_review |
|
@coderabbitai review |
Code Review by Qodo
1. Mirror comment repeats branch behavior
|
Jibril release gate: PASS
Core legs gate the pnpm upgrade verdict (capture → comment → permalink, rendered-comment correctness, security/trust posture, rollout-model compliance).
Optional legs unmet (never block the verdict)
Disclosed, not failing
Record
Legs map to past failures in |
PR Summary by QodoRoute L4 carve-outs to optional and normalize rendered evidence
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
|
Code review by qodo was updated up to the latest commit afc58c1 |
PR Code Suggestions ✨Warning
No code suggestions found for the PR. |
garnet-gate: jibril_version=v2.17.0
Summary
Two L4 sub-checks move to optional per the rollout decision, plus two gate-side grep false-negatives fixed — all observed on the first tiered run (#61's combination verdict):
registry.npmjs[.]org) and drops jibril's2.step-numbering prefix, so raw greps forregistry.npmjs.organd"2. Stop the action clock"missed evidence that renders correctly. The check now undefangs the body and tries the de-numbered step name — it reads what a reader sees.leg-tiers.ymlL4whycarries the carve-out so the config stays the source of truth for where the bar sits.Squash Commit Body
Checklist
garnet-release-testingapplied; this PR dogfoods the change.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Runtime evidence (Garnet)
Kernel-recorded execution record for head
afc58c16d097a9c34eefb94f3b342b076a47129b, mirrored verbatim fromthe sticky Garnet Runtime Review comment on this PR so reviewers that read only
the description ground in the same bytes. Facts only. Judgment stays with the
reviewer. Cite grounded findings as:
Execution record (verbatim mirror)
Execution Profiles recorded for 2 jobs, triggered by
afc58c1Garnet Jibril Release Gate/reproduce↗ · 3 destinations · unchangedRunner.Worker └─ bash └─ curl (step: "Stop the action clock") ├─ ○ localhost (dns resolver) └─ ○ registry.npmjs[.]org systemd └─ systemd-resolved └─ ○ 8.8.8.8View this job's Execution Profile in Garnet →
TS CI/test↗ · 8 destinations · unchangedView this job's Execution Profile in Garnet →
💡 How to read this
Runner.Worker ← process on a path └─ npm └─ node ← process that acted └─ ○ npmjs[.]org ← observed actionfollow a path downward to see what ran and what it did — each path to an observed action is an execution chain
names on the path = processes · ○ = observed action · (…) = context
+ only in the current record · − only in the previous record
Workload behaviour (Garnet)
Garnet Jibril Release Gate/reproduce· heade09e30b· 5 workload chains · 2 runner-platform chainsWorkload behaviour vs
ba67148: +0 −8 destinations−
github[.]com−
codeload.github[.]com−
nodejs[.]org−
node-registry.bit[.]cloud−
pnpm[.]io−
release-assets.githubusercontent[.]com−
unofficial-builds.nodejs[.]org−
npm.jsr[.]iorunner platform: +0 −19 destinations · not workload behaviour
5 workload chains · 2 destinations at head, 8 gone
localhostcurl,node,sudoregistry.npmjs[.]orgcurl,nodecodeload.github[.]comnodegithub[.]comgit-remote-http,nodenode-registry.bit[.]cloudnodenodejs[.]orgnodenpm.jsr[.]ionodepnpm[.]ionoderelease-assets.githubusercontent[.]comnodeunofficial-builds.nodejs[.]orgnoderunner platform · 2 chains · 2 destinations at head, 19 gone · no recorded workflow step
8.8.8.8systemd-resolvedlocalhostsudo140.82.112.22nginx140.82.113.21nginx140.82.114.21nginx169.254.169.123chronyd185.125.190.56chronyd185.125.190.57chronyd185.125.190.58chronyd192.168.127.1blacksmithd,sudo198.137.202.56chronyd23.143.196.204chronyd23.186.168.128chronyd5.161.94.12chronyd91.189.91.157chronydapi.snapcraft[.]iosnapdcloudfront.cdn.snapcraftcontent[.]comsnapdnodejs[.]orgpnpmproductionresultssa15.blob.core[.]windowsnoderegistry.npmjs[.]orgpnpmunofficial-builds.nodejs[.]orgpnpmrecorded at the kernel by Garnet · profile view →
Summary by CodeRabbit
Greptile Summary
Summary
Confidence Score: 5/5
Safe to merge; no blocking issues require changes.
There are no outstanding findings. No non-blocking concerns were identified.
Files Needing Attention: None.
Reviews (2): Last reviewed commit: "ci(garnet): normalize the rendered comme..." | Re-trigger Greptile