Repository navigation
[5/9] additional_model_arguments - #19
Merged
Merged
Conversation
This was referenced Jun 27, 2025
Merged
Merged
Closed
This was referenced Jun 27, 2025
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 27, 2025 19:23
9cfd9a6 to
f205d24
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 19:23
cd865ba to
30fb7a6
Compare
Owner
Author
|
@fabianlim we have this as a An then like |
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 27, 2025 20:21
f205d24 to
780f13a
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 20:21
30fb7a6 to
d97e9da
Compare
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 27, 2025 20:48
780f13a to
8bd01d8
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 20:48
d97e9da to
ea160f0
Compare
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 27, 2025 20:54
8bd01d8 to
aa6e4b7
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 20:54
ea160f0 to
7efb8d3
Compare
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 27, 2025 21:17
aa6e4b7 to
380cd14
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 21:17
7efb8d3 to
45a23bb
Compare
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 27, 2025 21:19
380cd14 to
f5460c2
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 21:19
45a23bb to
acae0d7
Compare
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 28, 2025 01:41
f5460c2 to
d9a59b6
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 28, 2025 01:41
acae0d7 to
525b935
Compare
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 28, 2025 01:48
d9a59b6 to
5b827c0
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 28, 2025 01:50
525b935 to
fd7d49d
Compare
garrett361
force-pushed
the
padding-free-squashing-4
branch
from
June 30, 2025 18:33
5b827c0 to
16a9336
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 30, 2025 19:29
fd7d49d to
fc3c0b3
Compare
fabianlim
reviewed
Jun 30, 2025
garrett361
force-pushed
the
padding-free-squashing-5
branch
2 times, most recently
from
June 30, 2025 20:49
ec1fec9 to
c807b6a
Compare
prev-branch: padding-free-squashing-4
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 30, 2025 20:49
c807b6a to
1d85428
Compare
fabianlim
reviewed
Jun 30, 2025
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 30, 2025 21:12
070042a to
47c512b
Compare
Owner
Author
|
also fixed an import that needs fixing before the tests can run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--additional_model_argumentsfor passing additional args to models (e.g. for z-loss or NoPE)