Repository navigation
[6/9] sync_each_batch option for grad accumulation - #20
Merged
Merged
Conversation
This was referenced Jun 27, 2025
Merged
garrett361
changed the title
This was referenced Jun 27, 2025
Merged
Closed
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 19:23
cd865ba to
30fb7a6
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
June 27, 2025 19:23
99016c3 to
bfd3b00
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 20:21
30fb7a6 to
d97e9da
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
June 27, 2025 20:22
bfd3b00 to
342d32a
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 20:48
d97e9da to
ea160f0
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
June 27, 2025 20:48
342d32a to
0ea1143
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 20:54
ea160f0 to
7efb8d3
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
June 27, 2025 20:54
0ea1143 to
b866596
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 21:17
7efb8d3 to
45a23bb
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
June 27, 2025 21:17
b866596 to
2d8996b
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 27, 2025 21:19
45a23bb to
acae0d7
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
June 27, 2025 21:19
2d8996b to
053c928
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 28, 2025 01:41
acae0d7 to
525b935
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
June 28, 2025 01:41
053c928 to
ab7a54b
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
from
June 28, 2025 01:50
525b935 to
fd7d49d
Compare
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
June 28, 2025 01:50
ab7a54b to
f5e19fa
Compare
garrett361
force-pushed
the
padding-free-squashing-5
branch
4 times, most recently
from
June 30, 2025 20:49
c807b6a to
1d85428
Compare
prev-branch: padding-free-squashing-5
garrett361
force-pushed
the
padding-free-squashing-6
branch
from
July 1, 2025 13:11
f5e19fa to
7a3d3dd
Compare
Owner
Author
|
I'm going to make this configurable with the previous behavior as the default |
garrett361
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
sync_each_batchargument for optionally synchronizing gradients after every batch when using gradient accumulation. Specifying--sync_each_batch Truecan dramatically reduce memory costs when using FSDP/DeepSpeed. The default isFalse, preserving the upstreamopen-instructbehavior.