Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #459 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 75 75
Lines 6863 6887 +24
=======================================
+ Hits 6842 6866 +24
Misses 21 21
Continue to review full report at Codecov.
|
This was referenced Jul 12, 2022
scpeters
reviewed
Jul 12, 2022
This was referenced Jul 14, 2022
scpeters
reviewed
Jul 16, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
scpeters
reviewed
Jul 19, 2022
This was referenced Jul 19, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
scpeters
reviewed
Jul 21, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Added fluid added mass support to the inertial class, as described on the Fluid Added Mass Proposal.
I also had to add addition operators to
Matrix6, because I forgot the one API I needed when I created the class in #455 🤦🏽Test it
Take a look at the new tests.
TODO
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸