Conversation
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
chapulina
approved these changes
Jan 20, 2021
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
LGTM, I just have some questions because I haven't used particles before.
Codecov Report
@@ Coverage Diff @@
## ign-msgs6 #127 +/- ##
==========================================
Coverage 84.59% 84.59%
==========================================
Files 7 7
Lines 818 818
==========================================
Hits 692 692
Misses 126 126 Continue to review full report at Codecov.
|
This was referenced Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores all attributes of a particle emitter.