Merged
Conversation
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
chapulina
added
🔮 dome
chapulina
reviewed
Jan 15, 2021
Contributor
chapulina
left a comment
chapulina
left a comment
There was a problem hiding this comment.
Just some preliminary comments.
iche033
reviewed
Jan 20, 2021
Contributor
iche033
left a comment
iche033
left a comment
There was a problem hiding this comment.
I think you still need to create the PR introducing the new particle emitter proto msg in ign-msgs?
Contributor
Author
It's now ready in gazebosim/gz-msgs#127. |
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
adlarkin
reviewed
Feb 8, 2021
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
adlarkin
reviewed
Feb 12, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Ashton Larkin <ashton@openrobotics.org> Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
adlarkin
force-pushed
the
particle_system_part2
branch
from
db0a633 to
2a6549e
Compare
adlarkin
added a commit
that referenced
this pull request
Feb 18, 2021
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org> Co-authored-by: Ashton Larkin <ashton@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
nkoenig
added a commit
that referenced
this pull request
Feb 18, 2021
* New ParticleEmitter component. Signed-off-by: Carlos Agüero <caguero@openrobotics.org> * Remove attribute name. Signed-off-by: Carlos Agüero <caguero@openrobotics.org> * Update particle emitter component to use ignition::msgs::ParticleEmitter. Signed-off-by: Carlos Agüero <caguero@openrobotics.org> * Simplify particle emitter component. Signed-off-by: Carlos Agüero <caguero@openrobotics.org> * Particle system - Part2 (#562) Signed-off-by: Carlos Agüero <caguero@osrfoundation.org> Co-authored-by: Ashton Larkin <ashton@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org> * bump msgs version to 6.3.0 Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Remove extra main Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added missing <set> Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com> Co-authored-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Ashton Larkin <ashton@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
nkoenig
pushed a commit
that referenced
this pull request
Nov 8, 2021
Point cloud to mesh tutorial Approved-by: Ian Chen <ichen@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It depends on gazebosim/gz-msgs#127 .
This pull request introduces the particle emitter system accepting SDF. It should parse the SDF properly and create the appropriate components.