Skip to content

Add missing include to PointCloudPackedUtils#218

Merged
chapulina merged 1 commit intoign-msgs5from
chapulina/5/include
Jan 21, 2022
Merged

Add missing include to PointCloudPackedUtils#218
chapulina merged 1 commit intoign-msgs5from
chapulina/5/include

Conversation

@chapulina
Copy link
Contributor

@chapulina chapulina commented Jan 21, 2022

🦟 Bug fix

Summary

This manifested itself quite late when packaging downstream Garden nightlies 😢 I wish some linter would have caught this on the original PR:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the bug Something isn't working label Jan 21, 2022
@chapulina chapulina requested a review from caguero as a code owner January 21, 2022 20:25
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #218 (05ed123) into ign-msgs5 (b5225fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs5     #218   +/-   ##
==========================================
  Coverage      85.27%   85.27%           
==========================================
  Files              9        9           
  Lines            903      903           
==========================================
  Hits             770      770           
  Misses           133      133           
Impacted Files Coverage Δ
...lude/ignition/msgs/detail/PointCloudPackedUtils.hh 94.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5225fe...05ed123. Read the comment docs.

@chapulina chapulina merged commit 8595461 into ign-msgs5 Jan 21, 2022
@chapulina chapulina deleted the chapulina/5/include branch January 21, 2022 21:06
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working 🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants