Skip to content

Add PointCloudPacked iterators#210

Merged
chapulina merged 7 commits intoign-msgs5from
chapulina/5/packed_utils
Jan 19, 2022
Merged

Add PointCloudPacked iterators#210
chapulina merged 7 commits intoign-msgs5from
chapulina/5/packed_utils

Conversation

@chapulina
Copy link
Contributor

🎉 New feature

Summary

Our PointCloudPacked message is equivalent to ROS's PointCloud2, but we don't have a good way of handling our message purely from Ignition.

This PR adapts PointCloud2Iterator for Ignition.

Test it

Run the tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner January 6, 2022 20:42
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #210 (b049cdb) into ign-msgs5 (9c71e5b) will increase coverage by 0.88%.
The diff coverage is 92.70%.

❗ Current head b049cdb differs from pull request most recent head 8446915. Consider uploading reports for the commit 8446915 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           ign-msgs5     #210      +/-   ##
=============================================
+ Coverage      84.38%   85.27%   +0.88%     
=============================================
  Files              7        9       +2     
  Lines            807      903      +96     
=============================================
+ Hits             681      770      +89     
- Misses           126      133       +7     
Impacted Files Coverage Δ
include/ignition/msgs/PointCloudPackedUtils.hh 84.21% <84.21%> (ø)
...lude/ignition/msgs/detail/PointCloudPackedUtils.hh 94.80% <94.80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c71e5b...8446915. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just two very minor comments.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Thanks for the review, @caguero , feedback addressed.

@chapulina chapulina requested a review from caguero January 19, 2022 16:47
@chapulina chapulina merged commit b5225fe into ign-msgs5 Jan 19, 2022
@chapulina chapulina deleted the chapulina/5/packed_utils branch January 19, 2022 17:49
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants