Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-msgs5 #210 +/- ##
=============================================
+ Coverage 84.38% 85.27% +0.88%
=============================================
Files 7 9 +2
Lines 807 903 +96
=============================================
+ Hits 681 770 +89
- Misses 126 133 +7
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
caguero
left a comment
There was a problem hiding this comment.
Looks good to me, just two very minor comments.
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
Thanks for the review, @caguero , feedback addressed. |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1 |
🎉 New feature
Summary
Our
PointCloudPackedmessage is equivalent to ROS'sPointCloud2, but we don't have a good way of handling our message purely from Ignition.This PR adapts PointCloud2Iterator for Ignition.
Test it
Run the tests
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸