This repository was archived by the owner on Mar 18, 2025. It is now read-only.
Use upstream's PointCloudPackedIterator#138
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added
the
needs upstream release
caguero
reviewed
Jan 20, 2022
Collaborator
caguero
left a comment
caguero
left a comment
There was a problem hiding this comment.
Looks good to me. Just waiting for CI to be happy when we release Ignition Msgs.
Contributor
Author
Thanks! We just need forward ports and a nightly |
chapulina
removed
the
needs upstream release
Contributor
Author
|
CI is happy 🟢 |
caguero
approved these changes
Jan 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Upstream point cloud utility functions #53
Requires
I cherry-picked that PR intoUpstream is available fromign-msgs'schapulina/9/tmp_packedbranch for Garden so this PR can be more easily tested.main