Skip to content

5 ➡️ 7#214

Merged
chapulina merged 4 commits intoign-msgs7from
chapulina/5_to_7
Jan 20, 2022
Merged

5 ➡️ 7#214
chapulina merged 4 commits intoign-msgs7from
chapulina/5_to_7

Conversation

@chapulina
Copy link
Contributor

@chapulina chapulina commented Jan 19, 2022

➡️ Forward port

Port ign-msgs5 to ign-msgs7

Branch comparison: ign-msgs7...ign-msgs5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

scpeters and others added 4 commits October 28, 2021 08:44
@scpeters
Utility_TEST: adjust expectations for 32-bit arch (#120) (#196)
e373e71 
PointCloud test has expectations that depend on memory alignment,
so add separate expectations for armhf to fix #63.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Prepare for 5.8.1 release (#197)
9c71e5b 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@chapulina
Add PointCloudPacked iterators (#210)
b5225fe 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
5 ➡️ 7
554fb0b 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner January 19, 2022 17:52
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jan 19, 2022
@chapulina chapulina mentioned this pull request Jan 19, 2022
Merged
@codecov
Copy link

codecov bot commented Jan 19, 2022 •
edited
Loading

Codecov Report

Merging #214 (03da440) into ign-msgs7 (5ab2a70) will increase coverage by 0.82%.
The diff coverage is 92.70%.

❗ Current head 03da440 differs from pull request most recent head 554fb0b. Consider uploading reports for the commit 554fb0b to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           ign-msgs7     #214      +/-   ##
=============================================
+ Coverage      84.78%   85.60%   +0.82%     
=============================================
  Files              7        9       +2     
  Lines            828      924      +96     
=============================================
+ Hits             702      791      +89     
- Misses           126      133       +7
Impacted Files Coverage Δ
include/ignition/msgs/PointCloudPackedUtils.hh 84.21% <84.21%> (ø)
...lude/ignition/msgs/detail/PointCloudPackedUtils.hh 94.80% <94.80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab2a70...554fb0b. Read the comment docs.

caguero
caguero reviewed Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention in the changelog the PointCloudPacked iterators?

@chapulina
Copy link
Contributor Author

chapulina commented Jan 20, 2022

Should we mention in the changelog the PointCloudPacked iterators?

Yup, we've been updating the changelog when we prepare for a release using this script: https://github.com/ignition-tooling/release-tools/blob/master/source_changelog.bash

@chapulina chapulina merged commit 0f8e672 into ign-msgs7 Jan 20, 2022
@chapulina chapulina deleted the chapulina/5_to_7 branch January 20, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caguero caguero caguero approved these changes

Assignees

No one assigned

Labels

🏢 edifice Ignition Edifice

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chapulina @caguero @j-rivero @osrf-triage @scpeters