Skip to content

8 ➡️ 9 (main)#217

Merged
chapulina merged 9 commits intomainfrom
chapulina/8_to_9
Jan 20, 2022
Merged

8 ➡️ 9 (main)#217
chapulina merged 9 commits intomainfrom
chapulina/8_to_9

Conversation

@chapulina
Copy link
Contributor

@chapulina chapulina commented Jan 20, 2022

➡️ Forward port

Port ign-msgs8 to main

Branch comparison: main...ign-msgs8

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

scpeters and others added 9 commits October 28, 2021 08:44
@scpeters
Utility_TEST: adjust expectations for 32-bit arch (#120) (#196)
e373e71 
PointCloud test has expectations that depend on memory alignment,
so add separate expectations for armhf to fix #63.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Prepare for 5.8.1 release (#197)
9c71e5b 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@chapulina
Document pose + spherical coordinates combination on spawn (#212)
190931c 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Add PointCloudPacked iterators (#210)
b5225fe 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
5 ➡️ 7
554fb0b 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
5 ➡️ 7 (#214)
0f8e672 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
7 ➡️ 8
451030a 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
7 ➡️ 8 (#216)
7111ad1 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
8 ➡️ 9 (main)
48452f3 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner January 20, 2022 18:30
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 20, 2022
@chapulina chapulina mentioned this pull request Jan 20, 2022
Merged
@codecov
Copy link

codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #217 (48452f3) into main (9a8b092) will increase coverage by 0.80%.
The diff coverage is 92.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   84.65%   85.46%   +0.80%     
==========================================
  Files           7        9       +2     
  Lines         860      956      +96     
==========================================
+ Hits          728      817      +89     
- Misses        132      139       +7
Impacted Files Coverage Δ
include/ignition/msgs/PointCloudPackedUtils.hh 84.21% <84.21%> (ø)
...lude/ignition/msgs/detail/PointCloudPackedUtils.hh 94.80% <94.80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8b092...48452f3. Read the comment docs.

@chapulina chapulina merged commit d3fc589 into main Jan 20, 2022
@chapulina chapulina deleted the chapulina/8_to_9 branch January 20, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caguero caguero caguero approved these changes

Assignees

No one assigned

Labels

🌱 garden Ignition Garden

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chapulina @caguero @j-rivero @osrf-triage @scpeters