Skip to content

7 ➡️ 8#216

Merged
chapulina merged 6 commits intoign-msgs8from
chapulina/7_to_8
Jan 20, 2022
Merged

7 ➡️ 8#216
chapulina merged 6 commits intoign-msgs8from
chapulina/7_to_8

Conversation

@chapulina
Copy link
Contributor

@chapulina chapulina commented Jan 20, 2022

➡️ Forward port

Port ign-msgs7 to ign-msgs8

Branch comparison: ign-msgs8...ign-msgs7

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

scpeters and others added 6 commits October 28, 2021 08:44
@scpeters
Utility_TEST: adjust expectations for 32-bit arch (#120) (#196)
e373e71 
PointCloud test has expectations that depend on memory alignment,
so add separate expectations for armhf to fix #63.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Prepare for 5.8.1 release (#197)
9c71e5b 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@chapulina
Add PointCloudPacked iterators (#210)
b5225fe 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
5 ➡️ 7
554fb0b 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
5 ➡️ 7 (#214)
0f8e672 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
7 ➡️ 8
451030a 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner January 20, 2022 18:05
@chapulina chapulina mentioned this pull request Jan 20, 2022
Merged
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #216 (451030a) into ign-msgs8 (190931c) will increase coverage by 0.82%.
The diff coverage is 92.70%.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-msgs8     #216      +/-   ##
=============================================
+ Coverage      84.56%   85.38%   +0.82%     
=============================================
  Files              7        9       +2     
  Lines            855      951      +96     
=============================================
+ Hits             723      812      +89     
- Misses           132      139       +7
Impacted Files Coverage Δ
include/ignition/msgs/PointCloudPackedUtils.hh 84.21% <84.21%> (ø)
...lude/ignition/msgs/detail/PointCloudPackedUtils.hh 94.80% <94.80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190931c...451030a. Read the comment docs.

@chapulina chapulina merged commit 7111ad1 into ign-msgs8 Jan 20, 2022
@chapulina chapulina deleted the chapulina/7_to_8 branch January 20, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caguero caguero caguero approved these changes

Assignees

No one assigned

Labels

🏯 fortress Ignition Fortress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chapulina @caguero @j-rivero @osrf-triage @scpeters