Add message definitions for the parameter component#241
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-msgs8 #241 +/- ##
==========================================
Coverage 85.38% 85.38%
==========================================
Files 9 9
Lines 951 951
==========================================
Hits 812 812
Misses 139 139 Continue to review full report at Codecov.
|
mjcarroll
left a comment
There was a problem hiding this comment.
I think that Any makes more sense if everything is going to stay protobuf.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Update copyright year 2021->2022. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
c1510f7 to
933c1e9
Compare
Codecov Report
@@ Coverage Diff @@
## ign-msgs8 #241 +/- ##
==========================================
Coverage 96.64% 96.64%
==========================================
Files 9 9
Lines 953 953
==========================================
Hits 921 921
Misses 32 32 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
… into ivanpauno/parameters-component8
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
caguero
left a comment
There was a problem hiding this comment.
Looks good to me. Just a minor comment but I'm approving.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
@caguero friendly ping |
🎉 New feature
Summary
Add message definitions to be used by the ignition transport parameter component.
See gazebosim/gz-transport#305.
Test it
See gazebosim/gz-sim#1431 for details of a demo.
Replaces #211.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.