-
Notifications
You must be signed in to change notification settings - Fork 57
Add message definitions for the parameter component #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
40ec562
wip
ivanpauno 60b6ae5
Update parameters related message definitions
ivanpauno 0b8db82
Add entity id to parameter declaration
ivanpauno 47ea277
* Update docstrings.
ivanpauno 933c1e9
wip
ivanpauno 297fcb2
Merge branch 'ign-msgs8' into ivanpauno/parameters-component8
caguero c4e29a7
Use google.protobuf.Any
ivanpauno bbe1408
Add msg type to communicate set/declaration errors
ivanpauno 4d949ed
Merge remote-tracking branch 'origin/ivanpauno/parameters-component8'…
ivanpauno 93e8790
Address peer review comments
ivanpauno 9a57c51
Merge branch 'ign-msgs8' into ivanpauno/parameters-component8
caguero abc8ed6
remove unneeded import
ivanpauno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright (C) 2022 Open Source Robotics Foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| syntax = "proto3"; | ||
| package ignition.msgs; | ||
| option java_package = "com.ignition.msgs"; | ||
| option java_outer_classname = "ParameterProtos"; | ||
|
|
||
| /// \ingroup ignition.msgs | ||
| /// \interface Parameter | ||
| /// \brief Representation of a parameter, used to request to set a parameter. | ||
|
|
||
| import "google/protobuf/any.proto"; | ||
|
|
||
| message Parameter | ||
| { | ||
| /// \brief Parameter name. | ||
| string name = 1; | ||
|
|
||
| /// \brief Serialized parameter value. | ||
| google.protobuf.Any value = 2; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright (C) 2022 Open Source Robotics Foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| syntax = "proto3"; | ||
| package ignition.msgs; | ||
| option java_package = "com.ignition.msgs"; | ||
| option java_outer_classname = "ParameterDeclarationProtos"; | ||
|
|
||
| /// \ingroup ignition.msgs | ||
| /// \interface ParameterDeclaration | ||
| /// \brief Representation of a parameter declaration. | ||
|
|
||
| message ParameterDeclaration | ||
| { | ||
| /// \brief Parameter name. | ||
| string name = 1; | ||
|
|
||
| /// \brief Parameter type, i.e. the associated protobuf type. | ||
| string type = 2; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright (C) 2022 Open Source Robotics Foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| syntax = "proto3"; | ||
| package ignition.msgs; | ||
| option java_package = "com.ignition.msgs"; | ||
| option java_outer_classname = "ParameterDeclarationsProtos"; | ||
|
|
||
| /// \ingroup ignition.msgs | ||
| /// \interface ParameterDeclarations | ||
| /// \brief Collection of parameter declarations. | ||
|
|
||
| import "ignition/msgs/parameter_declaration.proto"; | ||
|
|
||
| message ParameterDeclarations | ||
| { | ||
| /// \brief Parameter declarations. | ||
| repeated ParameterDeclaration parameter_declarations = 1; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright (C) 2022 Open Source Robotics Foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| syntax = "proto3"; | ||
| package ignition.msgs; | ||
| option java_package = "com.ignition.msgs"; | ||
| option java_outer_classname = "ParameterErrorProtos"; | ||
|
|
||
| /// \ingroup ignition.msgs | ||
| /// \interface ParameterError | ||
| /// \brief Parameter server errors for declare or set parameter. | ||
|
|
||
| message ParameterError | ||
| { | ||
| enum Type { | ||
| NO_ERROR = 0; | ||
| ALREADY_DECLARED = 1; | ||
| INVALID_TYPE = 2; | ||
| NOT_DECLARED = 3; | ||
| } | ||
| Type data = 1; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /* | ||
| * Copyright (C) 2022 Open Source Robotics Foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| syntax = "proto3"; | ||
| package ignition.msgs; | ||
| option java_package = "com.ignition.msgs"; | ||
| option java_outer_classname = "ParameterNameProtos"; | ||
|
|
||
| /// \ingroup ignition.msgs | ||
| /// \interface ParameterName | ||
| /// \brief Parameter name, used as a request to get a parameter. | ||
|
|
||
| message ParameterName | ||
| { | ||
| /// \brief Parameter name. | ||
| string name = 1; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright (C) 2022 Open Source Robotics Foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| syntax = "proto3"; | ||
| package ignition.msgs; | ||
| option java_package = "com.ignition.msgs"; | ||
| option java_outer_classname = "ParameterValueProtos"; | ||
|
|
||
| /// \ingroup ignition.msgs | ||
| /// \interface ParameterValue | ||
| /// \brief Representation of a parameter value, used as a response to get a parameter. | ||
|
|
||
| import "google/protobuf/any.proto"; | ||
|
|
||
| message ParameterValue | ||
| { | ||
| /// \brief Serialized protobuf message. | ||
| google.protobuf.Any data = 1; | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.