[garden] Added shininess to material message#251
Merged
chapulina merged 9 commits intogazebosim:mainfrom Jun 7, 2022
Merged
Conversation
9 tasks
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 15.90% 15.90% -0.01%
==========================================
Files 382 382
Lines 71409 71427 +18
==========================================
Hits 11361 11361
- Misses 60048 60066 +18 Continue to review full report at Codecov.
|
chapulina
added
the
needs upstream release
ahcorde
approved these changes
May 13, 2022
chapulina
reviewed
May 14, 2022
chapulina
removed
the
needs upstream release
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
WilliamLewww
force-pushed
the
wlew/shininess_garden
branch
from
783e7d4 to
e1b77d9
Compare
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
chapulina
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Depends on:
Summary
Adds the
shininessdata member tomaterial.proto. The new data member is required for setting the shininess value to visuals in gz-sim.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.