[garden] Apply shininess value to visuals#1483
Merged
chapulina merged 10 commits intogazebosim:mainfrom Jun 14, 2022
Merged
Conversation
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
chapulina
added
🌱 garden
ahcorde
previously requested changes
May 13, 2022
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
Add test to Conversions_TEST
Signed-off-by: tonylitianyu <tonylitianyu@gmail.com>
tonylitianyu
force-pushed
the
wlew/shininess_garden
branch
from
ff7d984 to
a1825ef
Compare
chapulina
previously requested changes
Jun 6, 2022
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1483 +/- ##
=======================================
Coverage 63.61% 63.62%
=======================================
Files 330 330
Lines 25834 25837 +3
=======================================
+ Hits 16435 16438 +3
Misses 9399 9399
Continue to review full report at Codecov.
|
scpeters
reviewed
Jun 13, 2022
Member
scpeters
left a comment
scpeters
left a comment
There was a problem hiding this comment.
I believe all comments by @chapulina and @ahcorde have been addressed
scpeters
approved these changes
Jun 13, 2022
chapulina
removed
the
needs upstream release
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Depends on:
Summary
Applies a shininess value to visuals from the given
<shininess>SDF element. Only works with ogre1 since ogre2 uses a different shading model.Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.