Allow moon and custom surfaces in spherical coords msg#279
Merged
adityapande-1995 merged 7 commits intomainfrom Jul 21, 2022
Merged
Allow moon and custom surfaces in spherical coords msg#279adityapande-1995 merged 7 commits intomainfrom
adityapande-1995 merged 7 commits intomainfrom
Conversation
…inition Signed-off-by: Aditya <aditya050995@gmail.com>
9 tasks
adityapande-1995
changed the title
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 85.44% 85.59% +0.14%
==========================================
Files 10 10
Lines 962 972 +10
==========================================
+ Hits 822 832 +10
Misses 140 140
Continue to review full report at Codecov.
|
Signed-off-by: Aditya <aditya050995@gmail.com>
jennuine
approved these changes
Jul 20, 2022
Signed-off-by: Aditya <aditya050995@gmail.com>
jennuine
approved these changes
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya aditya050995@gmail.com
🎉 New feature
Summary
Part of the feature : Supporting lunar DEMs and custom surfaces in spherical coordinates. Adds new fields
surface_axis_equatorialandsurface_axis_polarto spherical coordinates proto msg, allows new enumsMOON_SCSandCUSTOM_SURFACE.Test it
Added test cases.
Depends on
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸