Supply spherical coords when loading DEMs#1556
Conversation
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
898fa81 to
d406c73
Compare
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
- Coverage 63.61% 63.59% -0.02%
==========================================
Files 330 330
Lines 25931 25943 +12
==========================================
+ Hits 16495 16498 +3
- Misses 9436 9445 +9
Continue to review full report at Codecov.
|
|
I don't see a test case for |
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
|
Instead of installing the model through gz-sim, I think it's better to upload the model to fuel and use the Here is the uploaded moon model: https://app.gazebosim.org/OpenRobotics/fuel/models/Moon%20DEM |
jennuine
left a comment
There was a problem hiding this comment.
LGTM, nice work!
It would be nice to get a second pair of 👀 since I've made updates but if we can't by EOD, I'd say lets go ahead and merge this
chapulina
left a comment
There was a problem hiding this comment.
Just some minor nitpicks, LGTM once they're addressed
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
🎉 New feature
Summary
This PR makes
Physics.ccsupply the spherical coordinates object to the DEM object, so that the width and heights of the dem model are computed accurately.Depends on these PRs, and CI won't pass until then :
Example
An example world has been added with
MOON_SCStagChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸