Skip to content

Code cleanup#485

Merged
ahcorde merged 1 commit intogazebosim:mainfrom
ntfshard:cleanup
Feb 17, 2025
Merged

Code cleanup#485
ahcorde merged 1 commit intogazebosim:mainfrom
ntfshard:cleanup

Conversation

@ntfshard
Copy link
Contributor

@ntfshard ntfshard commented Feb 16, 2025

🦟 Bug fix

Fixes #

Summary

This PR fixes various typos and doing some minor C++ cleanup

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ntfshard ntfshard requested a review from caguero as a code owner February 16, 2025 14:46
@ntfshard
Code cleanup
8d70a10 
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
mjcarroll
mjcarroll approved these changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green ci

@ahcorde ahcorde merged commit 9f05e35 into gazebosim:main Feb 17, 2025
10 checks passed
@ntfshard ntfshard deleted the cleanup branch February 17, 2025 13:08
@ntfshard
Copy link
Contributor Author

ntfshard commented Mar 11, 2025

Not sure about process, but should it be backported?

@ahcorde
Copy link
Contributor

ahcorde commented Mar 11, 2025

https://github.com/Mergifyio backport gz-msgs11

@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2025 •
edited
Loading

backport gz-msgs11

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 11, 2025
@ntfshard @mergify
Code cleanup (#485)
d938b76 
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
(cherry picked from commit 9f05e35)

# Conflicts:
#	core/src/MessageFactory.cc
#	tutorials/message_generation.md
@mergify mergify bot mentioned this pull request Mar 11, 2025
Closed
8 tasks
@ahcorde
Copy link
Contributor

ahcorde commented Mar 11, 2025

@ntfshard do you mind to take a look #496 ? There are some conflicts in the backport

@ntfshard
Copy link
Contributor Author

ntfshard commented Mar 11, 2025 •
edited
Loading

@ntfshard do you mind to take a look #496 ? There are some conflicts in the backport

I guess I can, just worry about permissions.
And do we really need to backport it to this branches? I though this versions are already not supported

UPD, sorry, my bad. Confused versions and yes, I can't push to this branch, will make it in old-fashion way

ntfshard added a commit to ntfshard/gz-msgs that referenced this pull request Mar 11, 2025
@ntfshard
Code cleanup (gazebosim#485)
0f3ead3 
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
ntfshard added a commit to ntfshard/gz-msgs that referenced this pull request Mar 11, 2025
@ntfshard
Code cleanup (gazebosim#485)
54a6f82 
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
@ntfshard
Copy link
Contributor Author

ntfshard commented Mar 11, 2025

#497

caguero pushed a commit that referenced this pull request Mar 12, 2025
@ntfshard
Code cleanup (#485) (#497)
8d9ff35 
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Core development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ntfshard @ahcorde @mjcarroll