Skip to content

Code cleanup (backport #485)#496

Closed
mergify[bot] wants to merge 1 commit intogz-msgs11from
mergify/bp/gz-msgs11/pr-485
Closed

Code cleanup (backport #485)#496
mergify[bot] wants to merge 1 commit intogz-msgs11from
mergify/bp/gz-msgs11/pr-485

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 11, 2025

🦟 Bug fix

Fixes #

Summary

This PR fixes various typos and doing some minor C++ cleanup

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #485 done by Mergify.

Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
(cherry picked from commit 9f05e35)

# Conflicts:
#	core/src/MessageFactory.cc
#	tutorials/message_generation.md
@mergify mergify bot requested a review from caguero as a code owner March 11, 2025 10:03
@mergify mergify bot added the conflicts label Mar 11, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Mar 11, 2025

Cherry-pick of 9f05e35 has failed:

On branch mergify/bp/gz-msgs11/pr-485
Your branch is up to date with 'origin/gz-msgs11'.

You are currently cherry-picking commit 9f05e35.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Changelog.md
	modified:   Migration.md
	modified:   cmake/gz_msgs_generate.cmake
	modified:   core/generator/Generator.cc
	modified:   core/include/gz/msgs/Factory.hh
	modified:   core/include/gz/msgs/MessageFactory.hh
	modified:   core/include/gz/msgs/convert/AxisAlignedBox.hh
	modified:   core/include/gz/msgs/convert/Color.hh
	modified:   core/include/gz/msgs/convert/DiscoveryType.hh
	modified:   core/include/gz/msgs/convert/FuelMetadata.hh
	modified:   core/include/gz/msgs/convert/GeometryType.hh
	modified:   core/include/gz/msgs/convert/Inertial.hh
	modified:   core/include/gz/msgs/convert/JointType.hh
	modified:   core/include/gz/msgs/convert/PixelFormatType.hh
	modified:   core/include/gz/msgs/convert/Plane.hh
	modified:   core/include/gz/msgs/convert/Pose.hh
	modified:   core/include/gz/msgs/convert/Quaternion.hh
	modified:   core/include/gz/msgs/convert/ShaderType.hh
	modified:   core/include/gz/msgs/convert/SphericalCoordinates.hh
	modified:   core/include/gz/msgs/convert/StdTypes.hh
	modified:   core/include/gz/msgs/convert/Vector2.hh
	modified:   core/include/gz/msgs/convert/make_stubs.py
	modified:   core/include/gz/msgs/detail/dynamic_message_cast.hh
	modified:   core/src/DynamicFactory.hh
	modified:   examples/generating_custom_msgs/CMakeLists.txt
	modified:   examples/generating_custom_msgs/README.md
	modified:   examples/generating_custom_msgs/main.cc
	modified:   examples/using_gz_msgs/main.cc
	modified:   gz-msgs-extras.cmake.in
	modified:   proto/gz/msgs/data_load_options.proto
	modified:   proto/gz/msgs/discovery.proto
	modified:   proto/gz/msgs/response.proto
	modified:   test/integration/gz_TEST.cc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/MessageFactory.cc
	both modified:   tutorials/message_generation.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Mar 11, 2025
8 tasks
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Mar 11, 2025
@ntfshard ntfshard mentioned this pull request Mar 11, 2025
8 tasks
@caguero
Copy link
Collaborator

caguero commented Mar 12, 2025

Closed in favor of #497 .

@caguero caguero closed this Mar 12, 2025
@github-project-automation github-project-automation bot moved this from Inbox to Done in Core development Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants