Suppress protobuf related Windows warnings#334
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
|
CC: @Blast545 |
|
The |
It reliably fails on |
|
😢 The PR job seems to have more warnings that the reference buildfarm failure: (36 -> 55) |
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
|
Using the In MSVC < 16.10, this requires an additional It looks like we are using something newer than that, so I'm not sure where the issue is at this point. |
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 88.11% 88.11%
=======================================
Files 52 52
Lines 4848 4848
=======================================
Hits 4272 4272
Misses 576 576
Continue to review full report at Codecov.
|
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Backport #334 to citadel Signed-off-by: Michael Carroll <michael@openrobotics.org>
🦟 Bug fix
Summary
Followup to gz-msgs#256: gazebosim/gz-msgs#256 (comment)
There were a few more warnings present, which come from "unprotected" protobuf includes. This takes every protobuf (library, not generated) include statement and wraps them with the correct pragmas.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.