[citadel] Backport "Remove problematic discovery test #(336)"#339
Merged
chapulina merged 2 commits intoign-transport8from Jul 27, 2022
Merged
[citadel] Backport "Remove problematic discovery test #(336)"#339chapulina merged 2 commits intoign-transport8from
chapulina merged 2 commits intoign-transport8from
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
b2760c5 to
8fdd755
Compare
Signed-off-by: Michael Carroll <michael@openrobotics.org>
4003105 to
a0abde3
Compare
Codecov Report
@@ Coverage Diff @@
## ign-transport8 #339 +/- ##
=================================================
Coverage ? 83.61%
=================================================
Files ? 51
Lines ? 5035
Branches ? 0
=================================================
Hits ? 4210
Misses ? 825
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
Author
|
I'm also going to backport the relevant bits of #334 to clear up the Windows warnings. |
chapulina
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #336 to Citadel
Signed-off-by: Michael Carroll michael@openrobotics.org