Skip to content

[citadel] Backport "Remove problematic discovery test #(336)"#339

Merged
chapulina merged 2 commits intoign-transport8from
backport_336_citadel
Jul 27, 2022
Merged

[citadel] Backport "Remove problematic discovery test #(336)"#339
chapulina merged 2 commits intoign-transport8from
backport_336_citadel

Conversation

@mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jul 27, 2022

Backport of #336 to Citadel

Signed-off-by: Michael Carroll michael@openrobotics.org

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 27, 2022
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll force-pushed the backport_336_citadel branch from b2760c5 to 8fdd755 Compare July 27, 2022 16:44
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll force-pushed the backport_336_citadel branch from 4003105 to a0abde3 Compare July 27, 2022 17:05
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ign-transport8@0be3a49). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             ign-transport8     #339   +/-   ##
=================================================
  Coverage                  ?   83.61%           
=================================================
  Files                     ?       51           
  Lines                     ?     5035           
  Branches                  ?        0           
=================================================
  Hits                      ?     4210           
  Misses                    ?      825           
  Partials                  ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be3a49...a0abde3. Read the comment docs.

@mjcarroll mjcarroll marked this pull request as ready for review July 27, 2022 17:39
@mjcarroll mjcarroll requested a review from caguero as a code owner July 27, 2022 17:39
@mjcarroll
Copy link
Contributor Author

I'm also going to backport the relevant bits of #334 to clear up the Windows warnings.

@chapulina chapulina merged commit f686929 into ign-transport8 Jul 27, 2022
@chapulina chapulina deleted the backport_336_citadel branch July 27, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants