Skip to content

Remove Bionic from future releases (Garden+)#205

Merged
chapulina merged 2 commits intomainfrom
chapulina/main/rm/bionic
Mar 18, 2022
Merged

Remove Bionic from future releases (Garden+)#205
chapulina merged 2 commits intomainfrom
chapulina/main/rm/bionic

Conversation

@chapulina
Copy link
Contributor

Summary

ign-sensors7 will be on Garden.

Test it

No Bionic builds should be triggered.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added documentation Improvements or additions to documentation tests Broken or missing tests / testing infra labels Mar 11, 2022
@chapulina chapulina requested a review from iche033 as a code owner March 11, 2022 19:50
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #205 (ce8bbdb) into main (1133ee0) will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   71.26%   70.87%   -0.39%     
==========================================
  Files          30       30              
  Lines        3097     3114      +17     
==========================================
  Hits         2207     2207              
- Misses        890      907      +17     
Impacted Files Coverage Δ
src/ForceTorqueSensor.cc 80.55% <0.00%> (-4.74%) ⬇️
src/ImuSensor.cc 86.77% <0.00%> (-4.53%) ⬇️
src/RgbdCameraSensor.cc 74.89% <0.00%> (-0.33%) ⬇️
src/DepthCameraSensor.cc 73.96% <0.00%> (-0.31%) ⬇️
src/CameraSensor.cc 76.77% <0.00%> (-0.29%) ⬇️
src/ThermalCameraSensor.cc 60.38% <0.00%> (-0.24%) ⬇️
src/WideAngleCameraSensor.cc 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1133ee0...ce8bbdb. Read the comment docs.

@chapulina
Copy link
Contributor Author

I cancelled the Windows build because the buildfarm is swamped and that shouldn't be affected by this PR.

I think this is good to go!

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 62f7742 into main Mar 18, 2022
@chapulina chapulina deleted the chapulina/main/rm/bionic branch March 18, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation 🌱 garden Ignition Garden tests Broken or missing tests / testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants