Make rendering sensors' HasConnections function virtual#234
Merged
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
8 tasks
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 68.68% 68.58% -0.11%
==========================================
Files 34 34
Lines 3423 3428 +5
==========================================
Hits 2351 2351
- Misses 1072 1077 +5
Continue to review full report at Codecov.
|
chapulina
reviewed
Jun 13, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
ahcorde
approved these changes
Jun 30, 2022
ahcorde
previously requested changes
Jun 30, 2022
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
ups, some tests are not passing
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Contributor
Author
ok homebrew build is now green. d1bcce0 the Jammy rendering test failures have been happening for some time and I think they are not related to the changes here. |
chapulina
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Addresses the todo item about making the
HasConnection()virtual, specifically,virtual bool HasConnection() constfunction toRenderingSensorHasConnections()to theWideAngleCameraclassChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.